[BPF] set MTU on bpfin/out.cali to match host #8922
Merged
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
|
/merge-when-ready |
|
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it. |
fasaxc
requested changes
Jun 20, 2024
tomastigera
force-pushed
the
tomas-bpf-mtu-special-dev
branch
from
622b6ff
to
a5f6ba9
Compare
|
Removing "merge-when-ready" label due to new commits |
I enabled the vxlan mtu test for vxlan and it now also tests the bpfin.cali mtu |
tomastigera
force-pushed
the
tomas-bpf-mtu-special-dev
branch
from
a5f6ba9
to
c337121
Compare
|
/merge-when-ready |
|
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it. |
Set the MTU to match the smallest MTU of the host devices as per the current autodetection. That makes sure that if large MTU is used, the extra device does not create a bottleneck with a small MTU. Also when MTU changes, on host devices, it get adjusted automatically. If an overlay is used, the special device MTU is adjusted to the size of the overlay. Fixes projectcalico#8918
tomastigera
force-pushed
the
tomas-bpf-mtu-special-dev
branch
from
c337121
to
951685d
Compare
|
Removing "merge-when-ready" label due to new commits |
|
The only error has a fix here #8952 |
3 tasks
tomastigera
added a commit
that referenced
this pull request
Jun 28, 2024
…-release-v3.28 [release-v3.28] Auto pick #8922: set MTU on bpfin/out.cali to match host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the MTU to match the smallest MTU of the host devices as per the current autodetection. That makes sure that if large MTU is used, the extra device does not create a bottleneck with a small MTU. Also when MTU changes, on host devices, it get adjusted automatically. If an overlay is used, the special device MTU is adjusted to the size of the overlay.
Fixes #8868
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.