Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hcsshim version bump #9060

Merged

Conversation

coutinhop
Copy link
Contributor

Revert hcsshim version bump from v0.11.6 back to v0.11.4, as this was breaking Windows policies.

(original PR #8913)

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Revert hcsshim library version bump from v0.11.6 back to v0.11.4 to fix Windows policies.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@coutinhop coutinhop added release-note-required Change has user-facing impact (no matter how small) docs-not-required Docs not required for this change labels Jul 26, 2024
@coutinhop coutinhop self-assigned this Jul 26, 2024
@coutinhop coutinhop requested a review from a team as a code owner July 26, 2024 22:07
@marvin-tigera marvin-tigera added this to the Calico v3.28.1 milestone Jul 26, 2024
Revert hcsshim version bump from v0.11.6 back to v0.11.4,
as this was breaking Windows policies.

(original PR projectcalico#8913)
@marvin-tigera marvin-tigera merged commit 09eb6e4 into projectcalico:release-v3.28 Jul 27, 2024
2 checks passed
danudey added a commit that referenced this pull request Jul 30, 2024
danudey added a commit that referenced this pull request Jul 30, 2024
danudey added a commit that referenced this pull request Jul 30, 2024
* Update versions in charts
* Regenerate manifests
* Add release notes for v3.28.1
* Switch to python3 for release notes (and don't print gh token to stdout)
* Don't error on existing release-notes dir
* Remove extraneous release note for #9060
* Remove release notes for changes reverted by #9060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change merge-when-ready release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants