Execute MASQ rules after kube-proxy to avoid conflict - reenable vxlan csum offload #9091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e3bba6c.
marvin-tigera
added
release-note-required
fasaxc
requested changes
Aug 2, 2024
Calico needs to do MASQ for several reasons and kube-proxy does it when it forwards nodeports to another node. Calico conflicts with this MASQ in case it routes traffic to the destionation via tunnel. This may result in a conflict which triggers wrongly calculated checksums in case tx csum offloading is enabled on the tunnel device, which lead to disabling offloading on the tunnel and thus to significant performance hit. Do MASQ after kube-proxy means that if kube-proxy already did it, calico's is not executed - it would be a duplicate anyway. Other MASQ and SNAT cases in the calico chain are othogonal to the kube-proxy usecase and thus execute as kube-proxy does not do MASQ in that case. Note that unlik ein other chains where calico may do policy and thus needs to go first, calico does not execute any policy in POSTROUTING nat.
tomastigera
force-pushed
the
tomas-vxlan-csum-fix
branch
from
4c55f00
to
d0b66a4
Compare
fasaxc
approved these changes
Aug 6, 2024
fasaxc
added
docs-not-required
3 tasks
tomastigera
added a commit
that referenced
this pull request
Aug 7, 2024
…-release-v3.28 [release-v3.28] Auto pick #9091: Execute MASQ rules after kube-proxy to avoid conflict - reenable vxlan csum offload
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #8860
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.