test_examples.py: Add batch_run tests #144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This is quite fustrating, I will try to continue this after my vacation. |
rht
reviewed
Jul 22, 2024
| def get_batch_scripts(): | ||
| return [ | ||
| ("examples.bank_reserves", "batch_run"), | ||
| ("examples.sugarscape_g1mt", "run"), |
There was a problem hiding this comment.
This will take too long given that it will be 1000 steps.
There was a problem hiding this comment.
Maybe we can include some shorter examples somewhere?
There was a problem hiding this comment.
Yes, by calling them batch_run_short, run_short.
There was a problem hiding this comment.
Can we use a command line argument or an environment variable?
There was a problem hiding this comment.
I think it's easier to just name the functions.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test batch_run scripts, currently for bank_reserves and sugarscape_g1mt.
Requires #143 to be merged first, and part of projectmesa/mesa#2184.