CI: Add optional dependency for examples #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And everything is green again! ✅ We like green. |
Corvince
approved these changes
Aug 30, 2024
The Game of Life fast example needs scipy. Instead of adding it to our dev dependencies, I created a new, lighter examples optional dependency category (with SciPy)
FutureWarning can stay a FutureWarning in the CI, it doesn't need to be raised to an Error (note it also isn't suppresed). Otherwise we can't use experimental features in examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Game of Life fast example (projectmesa/mesa-examples#182) needs SciPy. Instead of adding it to our dev dependencies, I created a new, lighter examples optional dependency category (with SciPy).