Skip to content

Commit

Permalink
Preliminary support for set type
Browse files Browse the repository at this point in the history
still todo:

- flush interval option
- support strings, not just floats
- check for leaking goroutines during configuration reload

Signed-off-by: Bryan Larsen <bryan@larsen.st>
  • Loading branch information
bryanlarsen committed Feb 8, 2019
1 parent d5b22a2 commit dab1778
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 1 deletion.
77 changes: 76 additions & 1 deletion exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,25 @@ func (t *TimerEvent) Value() float64 { return t.value }
func (c *TimerEvent) Labels() map[string]string { return c.labels }
func (c *TimerEvent) MetricType() mapper.MetricType { return mapper.MetricTypeTimer }

type SetEvent struct {
metricName string
value float64
labels map[string]string
}

func (t *SetEvent) MetricName() string { return t.metricName }
func (t *SetEvent) Value() float64 { return t.value }
func (c *SetEvent) Labels() map[string]string { return c.labels }
func (c *SetEvent) MetricType() mapper.MetricType { return mapper.MetricTypeGauge }

type FlushEvent struct {
}

func (t *FlushEvent) MetricName() string { return "flush" }
func (t *FlushEvent) Value() float64 { return 0.0 }
func (c *FlushEvent) Labels() map[string]string { return map[string]string{} }
func (c *FlushEvent) MetricType() mapper.MetricType { return mapper.MetricTypeGauge }

type Events []Event

type LabelValues struct {
Expand All @@ -269,12 +288,25 @@ type LabelValues struct {
ttl time.Duration
}

type SetStore struct {
store map[string]map[float64]bool
events map[string]*SetEvent
}

func NewSetStore() *SetStore {
return &SetStore{
store: make(map[string]map[float64]bool),
events: make(map[string]*SetEvent),
}
}

type Exporter struct {
Counters *CounterContainer
Gauges *GaugeContainer
Summaries *SummaryContainer
Histograms *HistogramContainer
mapper *mapper.MetricMapper
Sets *SetStore
labelValues map[string]map[uint64]*LabelValues
}

Expand Down Expand Up @@ -366,6 +398,35 @@ func (b *Exporter) handleEvent(event Event) {
conflictingEventStats.WithLabelValues("counter").Inc()
}

case *FlushEvent:
log.Debugf("FlushEvent")
for k, v := range b.Sets.store {
setevent := b.Sets.events[k]

b.handleEvent(&GaugeEvent{
relative: false,
metricName: setevent.MetricName(),
value: float64(len(v)),
labels: setevent.labels,
})

b.Sets.store[k] = map[float64]bool{}
}

case *SetEvent:
store, found := b.Sets.store[metricName]
if found {
_, have := store[event.Value()]
if !have {
store[event.Value()] = true
}
} else {
b.Sets.store[metricName] = map[float64]bool{
event.Value(): true,
}
b.Sets.events[metricName] = ev
}

case *GaugeEvent:
gauge, err := b.Gauges.Get(
metricName,
Expand Down Expand Up @@ -486,6 +547,7 @@ func NewExporter(mapper *mapper.MetricMapper) *Exporter {
Gauges: NewGaugeContainer(),
Summaries: NewSummaryContainer(mapper),
Histograms: NewHistogramContainer(mapper),
Sets: NewSetStore(),
mapper: mapper,
labelValues: make(map[string]map[uint64]*LabelValues),
}
Expand Down Expand Up @@ -513,7 +575,11 @@ func buildEvent(statType, metric string, value float64, relative bool, labels ma
labels: labels,
}, nil
case "s":
return nil, fmt.Errorf("no support for StatsD sets")
return &SetEvent{
metricName: metric,
value: float64(value),
labels: labels,
}, nil
default:
return nil, fmt.Errorf("bad stat type %s", statType)
}
Expand Down Expand Up @@ -642,6 +708,15 @@ type StatsDUDPListener struct {
conn *net.UDPConn
}

func (b *Exporter) Ticker(e chan<- Events) {
ticker := time.NewTicker(10000 * time.Millisecond)
go func() {
for range ticker.C {
e <- []Event{&FlushEvent{}}
}
}()
}

func (l *StatsDUDPListener) Listen(e chan<- Events) {
buf := make([]byte, 65535)
for {
Expand Down
1 change: 1 addition & 0 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,5 +210,6 @@ func main() {
go watchConfig(*mappingConfig, mapper)
}
exporter := NewExporter(mapper)
exporter.Ticker(events)
exporter.Listen(events)
}

0 comments on commit dab1778

Please sign in to comment.