prombench: Added support for --bench.version and --bench.directory flags.
#812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements first phase of prometheus/proposals#41 Signed-off-by: bwplotka <bwplotka@gmail.com>
…` flags. See prometheus/proposals#41 for rationale. Prometheus job got updated with prometheus/prometheus#15682 Signed-off-by: bwplotka <bwplotka@gmail.com>
ArthurSens
reviewed
Dec 18, 2024
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
commented
Dec 19, 2024
| # In such a case we pull a prombench repository for the given branch or commit version | ||
| # and adjust PROMBENCH_DIR. As a result `make deploy` and `make clean` jobs | ||
| # will apply /manifests/ apply custom manifests or even node pools. | ||
| .PHONE: maybe_pull_custom_version |
There was a problem hiding this comment.
LOL, I just noticed ☎️ XD
It should be .PHONY: but I copied other commands 🙈 will fix later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See prometheus/proposals#41 for rationales.
Prometheus job got updated with prometheus/prometheus#15682
Signed-off-by: bwplotka bwplotka@gmail.com