Symfony 4 Compatibility #493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 1.7 # Conflicts: # composer.json
…improvements. Fixed possible bug related to simplexml_load_file(PHP Bug #73328). OptionsResolverInterface replaced with OptionsResolver
Backward compatibility changes for SF 4.1 and bellow.
|
@jaugustin, can you review my pool request? This branch will fix compatibility of Propel1 with Symfony 4+ |
Fixed path to directory with cache
Fixed compatibility with SF4.2
…mfony/config 4.1 and older
|
@jaugustin can you please help us with merge of this PR? Many people hope to get support of SF4&SF5 with Propel 1.6 |
|
All propel 2 dev should go into https://github.com/SkyFoxvn/PropelBundle as this will most likely be the follower of this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear PropelBundle team, I refactored the bundle to be compatible Symfony 4.0+(Not tested, but I hope it is compatible also with Symfony 3.4), so it's better to create a separate 1.7 branch in Propel repository, instead of merging with 1.6, because it may break compatibility with Symfony 3.0-3.3