Symfony 4.x compatibility for Propel1 #506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o resolve deprecation warnings for symfony 3.2
detect and handle difference in yaml format from symfony/yaml 3.3 and 3.4
fix issue with rendering propel profiler
* initial commit * composer validate and install * fix indentation * bump to latest version (1.7.2) * run phpunit tests * remove jenkins suffix from phpunit dist filename * add end of file newline * add php matrix * disable fail-fast * set continue-on-error for experimental * set default for experimental * add composer prefer-lowest * remove php 8.0 * remove travis ci * fix format * rename to ci.yml for better clarity * remove php 8 experimental again * remove continue-on-error Co-authored-by: Jeffrey Wong <jwong@dayspring-tech.com>
fix profiler for in if
|
Shall we revive this? |
|
All propel 2 dev should go into https://github.com/SkyFoxvn/PropelBundle as this will most likely be the follower of this now. |
dereuromark
reviewed
Dec 21, 2022
dereuromark
reviewed
Dec 21, 2022
| "propel/propel1": "^1.6.8", | ||
| "symfony/framework-bundle": "^3.0.2" | ||
| "propel/propel1": "^1.7.2", | ||
| "symfony/framework-bundle": "^3.4|^4.0" |
There was a problem hiding this comment.
Can we state the major PHP versions we support?
fix propel path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use PropelBundle and Propel1, and are trying to keep up with Symfony LTS. Since Propel2 is still in alpha, we made updates to PropelBundle to allow for Symfony 4 with Propel1.
This really ought to be against a "1.7" branch, but there isn't one in the upstream project.