SRU2024 #188
SRU2024 #188
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
📝 Walkthrough📝 Walkthrough<details>
<summary>📝 Walkthrough</summary>
## Walkthrough
The pull request introduces updates to the Prowide Core library, moving from version 9.4.x to 9.5.x. Key enhancements include modifications to the `getMUR` and `setMUR` methods in the `SwiftMessage` class to prioritize field 108 for system messages, the addition of a new method `isSystemMessage()`, and the introduction of `MtSequenceEnum` and `FieldEnum`. The `build.gradle` file has been updated to reflect changes in dependencies and versioning, including updates to `commons-lang3`, `gson`, and testing frameworks.
## Changes
| File(s) | Change Summary |
|---------------------------------------------|----------------------------------------------------------------------------------------------------|
| `CHANGELOG.md` | Updated to reflect changes in Prowide Core library, including version updates and new features. |
| `src/main/java/com/prowidesoftware/swift/...` | Updated method signatures for `getMUR()` and `setMUR()`, added `isSystemMessage()`, and introduced `MtSequenceEnum` and `FieldEnum`. |
| `build.gradle` | Updated dependencies (`commons-lang3`, `gson`, `junit-jupiter`, `assertj-core`, `xmlunit-core`) and modified versioning and testing configurations. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant ProwideCore
participant SwiftMessage
User->>ProwideCore: Send Swift Message
ProwideCore->>SwiftMessage: Process Message
SwiftMessage-->>ProwideCore: Return processed message
ProwideCore-->>User: Send response
|
#194) * CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-el-Field-exista * CU-86b1g1mye_SRU2024_Generar-un-enum-de-FieldNames-para-validar-que-el-Field-exista --------- Co-authored-by: Sebastian Zubrinic <sebastian@prowidesoftware.com>
…pos (#201) * CU-86b14j4e0_SRU2024_check-code-security-reports-at-GitHub-for-all-repos * CU-86b14j4e0_SRU2024_check-code-security-reports-at-GitHub-for-all-repos * CU-86b14j4e0_SRU2024_check-code-security-reports-at-GitHub-for-all-repos
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
⛔ Files ignored due to path filters (298)
src/generated/java/com/prowidesoftware/swift/SchemeConstantsA.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsB.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsE.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsF.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsH.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsM.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsN.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsO.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsP.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/SchemeConstantsR.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field101.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field102.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field103.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field104.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field105.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field106.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field107.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field108.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field109.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field110.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field111.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field113.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field114.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field115.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field116.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field117.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field118.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field119.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field11S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field120.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field121.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field122.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field123.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field124.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field125.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field126.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field127.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field128.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field129.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field12G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field130.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field132.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field133.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field134.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field135.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field136.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field137.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field13K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field140.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field141.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field142.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field143.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field144.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field14S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field151.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field152.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field153.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field15P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field165.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field16W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field171.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field172.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field173.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field174.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field175.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field177.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field179.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field17Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field18D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field199.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field19Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field202.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field203.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field204.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field206.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field208.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field209.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field20U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field21R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field22Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23R.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field23X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field242.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field243.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field24G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field251.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field252.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field253.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field254.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field255.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field256.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field257.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field258.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field259.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field25P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field260.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field263.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field264.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field26T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field27.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field270.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field271.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field272.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field280.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field281.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field28E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29A.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29B.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29O.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field29W.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field301.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field302.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field303.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field304.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field305.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field307.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30H.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30I.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30J.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30K.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30M.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30N.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Q.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30S.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30T.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30U.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30V.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30X.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Y.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field30Z.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field311.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field312.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field313.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31C.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31D.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31E.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31F.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31G.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31L.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31P.javais excluded by!**/generated/**src/generated/java/com/prowidesoftware/swift/model/field/Field31R.javais excluded by!**/generated/**
📒 Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- build.gradle (3 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
13-13: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
14-14: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
8-8: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
12-12: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
13-13: null
Bare URL used(MD034, no-bare-urls)
🔇 Additional comments (11)
build.gradle (5)
27-27: LGTM: SRU variable updated for 2024The update of the SRU variable to 'SRU2024' is in line with the PR objectives. This change reflects the annual SWIFT Release Update.
Please ensure that this change is consistently applied throughout the build file and doesn't cause any unintended side effects in version numbers or other configurations.
56-56: LGTM: commons-lang3 dependency updatedThe update of commons-lang3 from 3.12.0 to 3.14.0 is a good practice to keep dependencies current.
Please review the changelog for commons-lang3 3.14.0 to ensure there are no breaking changes that might affect the project.
57-57: LGTM: gson dependency updatedThe update of gson from 2.9.0 to 2.11.0 is a good practice to keep dependencies current.
Please review the changelog for gson 2.11.0 to ensure there are no breaking changes that might affect the project.
Line range hint
1-379: Summary of changes and potential impactThe changes in this build.gradle file are primarily focused on:
- Updating the SRU (SWIFT Release Update) version to 2024
- Updating various dependencies to their latest versions
These changes align with the PR objectives and are generally good practices for maintaining the project. However, there are a few points to consider:
- The SRU update might affect version numbers and other configurations in the project. Ensure this change is consistently applied across the codebase.
- The dependency updates, while beneficial, may introduce breaking changes. It's crucial to review the changelogs of each updated dependency and test thoroughly.
- There's an inconsistency in the xmlunit dependency versions that should be addressed.
To ensure these changes don't introduce any issues:
- Run a full build and test suite to catch any potential compatibility issues.
- Review the project's CI/CD pipeline results after these changes.
- If possible, perform a staged rollout or additional testing in a pre-production environment.
65-69:⚠️ Potential issueLGTM: Test dependencies updated, but note xmlunit version inconsistency
The updates to junit-jupiter, assertj-core, and xmlunit-core are good practices to keep dependencies current.
Please review the changelogs for junit-jupiter 5.10.2, assertj-core 3.25.3, and xmlunit-core 2.10.0 to ensure there are no breaking changes that might affect the project's tests.
There's an inconsistency in the xmlunit dependency versions:
- xmlunit-core is updated to 2.10.0
- xmlunit-matchers and xmlunit-assertj remain at 2.9.0
Consider updating all xmlunit dependencies to the same version to ensure compatibility and avoid potential issues.
CHANGELOG.md (6)
3-5: New features and improvements in the SNAPSHOT versionThe SNAPSHOT version 9.5.2 introduces two significant changes:
- A new
FieldEnumwith all available field names, which should improve field handling and validation.- Code security improvements based on CodeQL recommendations, indicating a focus on enhancing the library's security.
These changes demonstrate ongoing development and a commitment to both feature expansion and security.
🧰 Tools
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
7-10: Version 9.5.1 updatesVersion 9.5.1, dated June 2024, includes two notable changes:
- Addition of IBAN validation for Egypt's local account structure (PW-1913), expanding the library's geographical coverage.
- Restoration of a deprecated method in the MT210 class, which might be for backward compatibility reasons.
These updates show continued improvement in international banking support and maintenance of existing functionality.
🧰 Tools
🪛 Markdownlint
8-8: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
8-8: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
11-15: Significant updates in version 9.5.0Version 9.5.0, dated May 2024, brings several important updates:
- SWIFT Standard release update for 2024, to be live on November 16, 2025.
- Annual revision of the deprecation phase, with a link to the deprecation policy.
- Dependency updates: commons-lang3 to 3.14.0 and gson to 2.11.0.
These changes reflect the library's alignment with the latest SWIFT standards and its commitment to using up-to-date dependencies. The early preparation for the 2025 SWIFT update is noteworthy.
🧰 Tools
🪛 Markdownlint
12-12: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
13-13: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
14-14: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
12-12: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
13-13: null
Bare URL used(MD034, no-bare-urls)
Line range hint
17-85: Summary of changes in versions 9.4.0 to 9.4.16This section of the changelog covers multiple minor versions from 9.4.0 to 9.4.16, showcasing a series of incremental improvements and bug fixes:
- Field-specific updates: Various fields (e.g., 37K, 59F, 29O, 30I, 14[H,K,L,M,N,O], 29J, 31R, 24G, 44J) received fixes or enhancements.
- New features: Added support for DistinguishedName with Builder, new getters for specific MTs, and JSON-related improvements.
- Performance enhancements: Fixed stack overflow issues and improved parsing efficiency.
- API improvements: Added new methods to SwiftTagListBlock, enhanced existing APIs, and improved consistency in method naming.
- Bug fixes: Addressed issues in parsing, validation patterns, and specific field behaviors.
- Dependency updates: Updated to SWIFT Standard release 2023 and revised the deprecation phase.
These changes demonstrate a commitment to maintaining and improving the library, addressing user needs, and keeping up with SWIFT standards.
🧰 Tools
🪛 LanguageTool
[typographical] ~17-~17: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ncy update: gson -> 2.11.0' #### 9.4.16 - May 2024 * (PW-1862) Added NarrativeFr...(DASH_RULE)
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
13-13: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
14-14: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
18-18: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
17-17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
8-8: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
12-12: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
18-18: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
13-13: null
Bare URL used(MD034, no-bare-urls)
Line range hint
87-1028: Historical overview of major changes from version 7.0.0 to 9.3.15This extensive changelog section provides valuable insights into the evolution of the Prowide Core library:
Major version milestones:
- 7.0.0: Introduced MX message support, new meta-data model, and complete MT helper classes.
- 8.0.0: Increased JRE requirement to Java 1.8 and implemented SWIFT Standard release update 2019.
- 9.0.0: (Not explicitly mentioned, but implied by the version numbering)
Continuous improvement in SWIFT standards support:
- Regular updates to align with annual SWIFT Standard releases.
- Ongoing additions and refinements to MT and MX message types and fields.
API enhancements:
- Introduction of builder patterns, fluent APIs, and more intuitive interfaces.
- Addition of JSON and XML serialization/deserialization capabilities.
Performance and security:
- Various optimizations and bug fixes throughout the versions.
- Security improvements, including better handling of XML parsing.
Modernization:
- Gradual increase in Java version requirements.
- Updates to third-party dependencies.
Documentation and usability:
- Improvements in JavaDoc and code examples.
- Enhanced error messages and logging.
This historical overview showcases the library's commitment to staying current with SWIFT standards while continuously improving its API, performance, and feature set.
🧰 Tools
🪛 LanguageTool
[typographical] ~17-~17: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ncy update: gson -> 2.11.0' #### 9.4.16 - May 2024 * (PW-1862) Added NarrativeFr...(DASH_RULE)
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
13-13: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
14-14: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
18-18: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
17-17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
8-8: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
12-12: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
18-18: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
13-13: null
Bare URL used(MD034, no-bare-urls)
Line range hint
1-1028: Comprehensive and well-maintained changelogThis CHANGELOG.md file is an excellent example of a well-maintained, comprehensive changelog that provides valuable information to users and developers:
- Consistent structure: Each version is clearly labeled with its number and release date, followed by a bulleted list of changes.
- Detailed descriptions: Changes are described with sufficient detail, often including issue numbers or specific field/MT references.
- Wide coverage: The changelog covers an extensive period, from version 7.0.0 to the current 9.5.2 SNAPSHOT, allowing users to track the library's evolution.
- Balance of information: It includes a good mix of new features, improvements, bug fixes, and standard compliance updates.
- Transparency: The changelog clearly indicates when breaking changes or deprecations occur, helping users plan for upgrades.
Overall, this changelog serves as a valuable resource for understanding the library's development history, planning upgrades, and appreciating the ongoing efforts to improve and maintain the Prowide Core library.
🧰 Tools
🪛 LanguageTool
[typographical] ~17-~17: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...ncy update: gson -> 2.11.0' #### 9.4.16 - May 2024 * (PW-1862) Added NarrativeFr...(DASH_RULE)
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
13-13: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
14-14: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
18-18: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
17-17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
8-8: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
12-12: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
18-18: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
13-13: null
Bare URL used(MD034, no-bare-urls)
| @@ -34,6 +34,7 @@ scmVersion { | |||
| } | |||
| } | |||
| project.version = "${SRU}-${scmVersion.version}" | |||
| //project.version = "${SRU}-9.5.0" | |||
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consider removing the commented-out version override
This commented-out line doesn't affect the build but might lead to confusion. If it's no longer needed for version overrides, consider removing it to keep the build file clean.
… in block 4 over block 3 for system messages (category 0) (#211)
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
13-13: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
16-16: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
17-17: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
18-18: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
11-11: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
15-15: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
8-8: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
12-12: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
16-16: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
17-17: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
CHANGELOG.md (1)
7-8: 🧹 Nitpick (assertive)
Security improvements need more details.
The entry "Code security improvements as per CodeQL recommendations" is vague. Consider adding more specific details about what security issues were addressed.
Let's check for any security-related commits:
Consider expanding the security improvements entry with:
- Specific security issues addressed
- Impact of the fixes
- Any CVE references if applicable
✅ Verification successful
Let me analyze the changelog entries to verify if there are any security-related changes that should be documented in more detail.
Based on the output, I can now provide a specific response about the security improvements mentioned in the changelog.
Security improvements should be documented in more detail
The entry "Code security improvements as per CodeQL recommendations" refers to specific changes that can be detailed:
- Added CodeQL security scanning workflow for automated code analysis
- Implemented security-and-quality query suite for enhanced scanning
- Fixed potential XML parsing vulnerabilities in StAX parser usage
- Improved security in message digest handling
- Enhanced input validation and parameter checks
The security improvements are well-defined in the codebase through the implementation of CodeQL scanning and associated fixes. The changes are tracked in multiple commits and include both infrastructure (CodeQL workflow) and code-level security enhancements. While the changelog entry is concise, the actual security improvements are properly implemented and documented in the code.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Search for security-related commits and CodeQL fixes
# Search for security-related commits
git log --grep="security\|CodeQL\|CVE\|vulnerability" --since="2024-10-01"
# Search for CodeQL configuration and workflow files
fd -e yml -e yaml . .github/workflows/ -x grep -l "codeql"
Length of output: 271681
Script:
#!/bin/bash
# Search for security-related changes in recent commits and changelog entries
git log --since="2024-09-01" --until="2024-10-31" -p | grep -i "security\|codeql\|vulnerability\|cve" -A 5
Length of output: 21394
🧰 Tools
🪛 Markdownlint
8-8: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
8-8: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
CHANGELOG.md
Outdated
| #### 9.5.3 - SNAPSHOT | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consider standardizing the version entry format.
The SNAPSHOT version entry could be improved for consistency:
- Add the date (month and year) like other entries
- Use consistent bullet point indentation
Apply this formatting:
-#### 9.5.3 - SNAPSHOT
- * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
- * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)
+#### 9.5.3 - SNAPSHOT - November 2024
+* (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
+* Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.3 - SNAPSHOT | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | |
| #### 9.5.3 - SNAPSHOT - November 2024 | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) |
🧰 Tools
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
9-9: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
10-10: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
13-13: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
14-14: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
17-17: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
18-18: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
8-8: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
12-12: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
16-16: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
9-9: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
13-13: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
17-17: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
18-18: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
CHANGELOG.md (1)
16-20:
The SWIFT Standard 2024 changes should be documented more comprehensively.
The current changelog entry is insufficient as it only mentions the update without detailing important changes. The following breaking changes have been identified and should be documented:
- Removed fields in SRU2024:
- Field29K (Narrative)
- Field37P (Amount)
- Field37U (Amount)
- Field39D (Multiline)
The changelog should include:
- A link to the full deprecation policy at https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/
- List of removed fields and their impact
- Migration guidance for users of removed fields
- Any new features or functionality introduced
🧰 Tools
🪛 Markdownlint
17-17: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
18-18: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
16-16: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
17-17: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
18-18: null
Bare URL used
(MD034, no-bare-urls)
CHANGELOG.md
Outdated
| #### 9.5.3 - SNAPSHOT | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consider standardizing the version entry format.
The SNAPSHOT version entry could be improved for consistency:
- Add the date (month and year) like other entries
- Use consistent bullet point indentation
Apply this formatting:
-#### 9.5.3 - SNAPSHOT
- * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
- * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
- * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)
+#### 9.5.3 - SNAPSHOT - November 2024
+* (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
+* Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
+* Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.3 - SNAPSHOT | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | |
| #### 9.5.3 - SNAPSHOT - November 2024 | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) |
🧰 Tools
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
10-10: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
11-11: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
14-14: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
18-18: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
21-21: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
4-4: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
9-9: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
13-13: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
17-17: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
10-10: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
14-14: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
18-18: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
19-19: null
Bare URL used
(MD034, no-bare-urls)
| * Dependency update: commons-lang3 -> 3.14.0' | ||
| * Dependency update: gson -> 2.11.0' |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Use consistent format for dependency updates.
The dependency updates should follow a consistent format and include the reason for the update.
Apply this formatting:
- * Dependency update: commons-lang3 -> 3.14.0'
- * Dependency update: gson -> 2.11.0'
+* Dependencies:
+ * Updated commons-lang3 to 3.14.0 (security fixes and performance improvements)
+ * Updated gson to 2.11.0 (security fixes and new features)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * Dependency update: commons-lang3 -> 3.14.0' | |
| * Dependency update: gson -> 2.11.0' | |
| * Dependencies: | |
| * Updated commons-lang3 to 3.14.0 (security fixes and performance improvements) | |
| * Updated gson to 2.11.0 (security fixes and new features) |
🧰 Tools
🪛 Markdownlint
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
21-21: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
CHANGELOG.md
Outdated
| #### 9.5.3 - SNAPSHOT | ||
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Standardize the version entry format and improve changelog structure.
The latest version entry needs formatting improvements for consistency:
- Add date (month and year)
- Use consistent bullet point indentation
- Group related changes together
Apply this formatting:
-#### 9.5.3 - SNAPSHOT
- * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release
- * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
- * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
- * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)
+#### 9.5.3 - SNAPSHOT - November 2024
+* (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release
+* System Messages Enhancements:
+ * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
+ * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)
+* Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.3 - SNAPSHOT | |
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | |
| #### 9.5.3 - SNAPSHOT - November 2024 | |
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | |
| * System Messages Enhancements: | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas |
🧰 Tools
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
4-4: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
11-11: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
16-16: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
21-21: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
22-22: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
4-4: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
10-10: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
14-14: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
11-11: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
15-15: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
19-19: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
20-20: null
Bare URL used
(MD034, no-bare-urls)
| * SWIFT Standard release update 2024 (live 16 November 2025) | ||
| * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Document SWIFT Standard 2024 changes comprehensively.
The SWIFT Standard Release Update 2024 (SRU2024) is a major change that should be documented more thoroughly, including:
- Breaking changes
- Migration guidelines
- Specific message types affected
- New features or deprecated functionality
Would you like me to help create a comprehensive section about SRU2024 changes?
🧰 Tools
🪛 Markdownlint
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
20-20: null
Bare URL used
(MD034, no-bare-urls)
| #### 9.5.1 - June 2024 | ||
| * (PW-1913) Added IBAN validation for Egypt local account structure | ||
| * Restore deprecated method in MT210 class | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Fix formatting inconsistencies.
The entry has inconsistent formatting and an unnecessary empty line between bullet points.
Apply this formatting:
#### 9.5.1 - June 2024
- * (PW-1913) Added IBAN validation for Egypt local account structure
- * Restore deprecated method in MT210 class
-
+* (PW-1913) Added IBAN validation for Egypt local account structure
+* Restore deprecated method in MT210 class📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.1 - June 2024 | |
| * (PW-1913) Added IBAN validation for Egypt local account structure | |
| * Restore deprecated method in MT210 class | |
| #### 9.5.1 - June 2024 | |
| * (PW-1913) Added IBAN validation for Egypt local account structure | |
| * Restore deprecated method in MT210 class |
🧰 Tools
🪛 Markdownlint
15-15: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
16-16: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
14-14: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
15-15: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
| #### 9.5.2 - October 2024 | ||
| * Added new `FieldEnum` with all the available field names | ||
| * Code security improvements as per CodeQL recommendations | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Standardize bullet point indentation.
The bullet points should use single-space indentation for consistency.
Apply this formatting:
#### 9.5.2 - October 2024
- * Added new `FieldEnum` with all the available field names
- * Code security improvements as per CodeQL recommendations
+* Added new `FieldEnum` with all the available field names
+* Code security improvements as per CodeQL recommendations📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.2 - October 2024 | |
| * Added new `FieldEnum` with all the available field names | |
| * Code security improvements as per CodeQL recommendations | |
| #### 9.5.2 - October 2024 | |
| * Added new `FieldEnum` with all the available field names | |
| * Code security improvements as per CodeQL recommendations |
🧰 Tools
🪛 Markdownlint
11-11: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
10-10: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
11-11: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
CHANGELOG.md
Outdated
| #### 9.5.3 - SNAPSHOT | ||
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Fix formatting and remove duplicate entry.
The latest version entry needs formatting improvements and has a duplicate entry:
- The version header is missing the date
- Bullet points have inconsistent indentation
- The
MtSequenceEnumaddition is mentioned twice
Apply this formatting:
-#### 9.5.3 - SNAPSHOT
- * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release
- * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
- * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
- * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)
- * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
+#### 9.5.3 - SNAPSHOT - November 2024
+* (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release
+* (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
+* Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
+* Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.3 - SNAPSHOT | |
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| #### 9.5.3 - SNAPSHOT - November 2024 | |
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) |
🧰 Tools
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
4-4: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
11-11: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
15-15: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
16-16: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
21-21: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
22-22: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
4-4: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
10-10: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
14-14: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
11-11: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
15-15: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
19-19: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
20-20: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (1)
CHANGELOG.md (1)
14-17: 🧹 Nitpick (assertive)
Remove unnecessary empty line between entries.
The version entry has an unnecessary empty line between bullet points.
Apply this formatting:
#### 9.5.1 - June 2024
- * (PW-1913) Added IBAN validation for Egypt local account structure
- * Restore deprecated method in MT210 class
-
+* (PW-1913) Added IBAN validation for Egypt local account structure
+* Restore deprecated method in MT210 classLikely invalid or redundant comment.
🧰 Tools
🪛 Markdownlint
15-15: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
16-16: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
14-14: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
15-15: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
| * Restore deprecated method in MT210 class | ||
|
|
||
| #### 9.5.0 - May 2024 | ||
| * SWIFT Standard release update 2024 (live 16 November 2025) |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Document SWIFT Standard 2024 changes comprehensively.
The SWIFT Standard Release Update 2024 (SRU2024) is a major change that should be documented more thoroughly, including:
- Breaking changes
- Migration guidelines
- Specific message types affected
- New features or deprecated functionality
Would you like me to help create a comprehensive section about SRU2024 changes?
🧰 Tools
🪛 Markdownlint
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
19-19: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
| #### 9.5.2 - October 2024 | ||
| * Added new `FieldEnum` with all the available field names | ||
| * Code security improvements as per CodeQL recommendations |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Standardize bullet point indentation.
The bullet points should use single-space indentation for consistency.
Apply this formatting:
#### 9.5.2 - October 2024
- * Added new `FieldEnum` with all the available field names
- * Code security improvements as per CodeQL recommendations
+* Added new `FieldEnum` with all the available field names
+* Code security improvements as per CodeQL recommendations📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.2 - October 2024 | |
| * Added new `FieldEnum` with all the available field names | |
| * Code security improvements as per CodeQL recommendations | |
| #### 9.5.2 - October 2024 | |
| * Added new `FieldEnum` with all the available field names | |
| * Code security improvements as per CodeQL recommendations |
🧰 Tools
🪛 Markdownlint
11-11: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
12-12: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
10-10: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
11-11: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
| #### 9.5.0 - May 2024 | ||
| * SWIFT Standard release update 2024 (live 16 November 2025) | ||
| * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | ||
| * Dependency update: commons-lang3 -> 3.14.0' | ||
| * Dependency update: gson -> 2.11.0' |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix formatting issues in version 9.5.0 entry.
The entry has several formatting issues:
- Inconsistent bullet point indentation
- Bare URL that should be properly formatted
- Unnecessary trailing quotes in dependency updates
Apply this formatting:
#### 9.5.0 - May 2024
- * SWIFT Standard release update 2024 (live 16 November 2025)
- * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/)
- * Dependency update: commons-lang3 -> 3.14.0'
- * Dependency update: gson -> 2.11.0'
+* SWIFT Standard release update 2024 (live 16 November 2025)
+* Yearly revision of deprecation phase (see [deprecation policy](https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/))
+* Dependencies:
+ * Updated commons-lang3 to 3.14.0 (security fixes and performance improvements)
+ * Updated gson to 2.11.0 (security fixes and new features)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.0 - May 2024 | |
| * SWIFT Standard release update 2024 (live 16 November 2025) | |
| * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | |
| * Dependency update: commons-lang3 -> 3.14.0' | |
| * Dependency update: gson -> 2.11.0' | |
| #### 9.5.0 - May 2024 | |
| * SWIFT Standard release update 2024 (live 16 November 2025) | |
| * Yearly revision of deprecation phase (see [deprecation policy](https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/)) | |
| * Dependencies: | |
| * Updated commons-lang3 to 3.14.0 (security fixes and performance improvements) | |
| * Updated gson to 2.11.0 (security fixes and new features) |
🧰 Tools
🪛 Markdownlint
19-19: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
20-20: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
21-21: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
22-22: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
18-18: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
19-19: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
20-20: null
Bare URL used
(MD034, no-bare-urls)
| #### 9.5.3 - November 2024 | ||
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix duplicate entry and standardize version format.
The latest version entry has the following issues:
- Duplicate entry for
MtSequenceEnumaddition - Inconsistent bullet point indentation
Apply this formatting:
-#### 9.5.3 - November 2024
- * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release
- * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
- * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
- * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)
- * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
+#### 9.5.3 - SNAPSHOT - November 2024
+* (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release
+* (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0)
+* Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas
+* Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #### 9.5.3 - November 2024 | |
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| #### 9.5.3 - SNAPSHOT - November 2024 | |
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | |
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | |
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | |
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) |
🧰 Tools
🪛 Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
5-5: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
6-6: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
7-7: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
8-8: Expected: 0; Actual: 2
Unordered list indentation
(MD007, ul-indent)
4-4: Expected: 0 or 2; Actual: 1
Trailing spaces
(MD009, no-trailing-spaces)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
Summary by CodeRabbit
New Features
FieldEnumfor enhanced field name handling.isSystemMessage()to identify system messages.MtSequenceEnumfor improved sequence handling.Bug Fixes
Security Improvements
Documentation
Chores