M850 add possibility to set sheet as active

[dawidpieper]

#2201 added possibility to set sheet parameters using new M850 gCode, but there still lacks possibility to set or check what sheet is active.
Added A parameter to set sheet as Active.
Related to #3610

New usage

M850 S[sheet] Z[offset] L[label] B[Bed temp] P[PINDA temp] A[is active]

• A1 enables the selected sheet
• • If A set to 0 or missing, current status is reported

[github-actions]

Target	ΔFlash (bytes)	ΔSRAM (bytes)
MK3S_MULTILANG	136	0
MK3_MULTILANG	114	0

[dawidpieper]

My oversight. Now I standardized the formatting in all the code responsible for this gCode.

[wavexx]

Looks very sensible to me. @gudnimg what do you think?

[wavexx]

would be nice to have an empty line like the other block

[dawidpieper]

I made suggested optimizations, but as for the last if statement, I think the code may be a bit less readable now. Previously only conditions for bHasXXX were used and I think the compiler optimizes it well. But these are only my feelings. :)

[gudnimg]

Code size seems to have increased according to our Github bot 🤔 I wonder why

[dawidpieper]

I don't know AVR architecture as well. In fact I'm not sure if statement
bIsActive |= code_value_uint8() || (eeprom_read_byte(&(EEPROM_Sheets_base->active_sheet)) == iSel);
is calculated in RAM or CPU registers.
May it be the issue here?

[gudnimg]

It's measured in Flash memory and SRAM. The if statement is in Flash memory, while global variables and static variables are in SRAM.

I usually stash my changes and check the current build stats:

Then re-apply my stash and re-build to check if the optimisation reduces code size (memory). We try to save memory whenever we can as we don't have much left of Flash (94% full).

[gudnimg]

Approving, but I have not tested the changes.

[dawidpieper]

Thanks, original commit seemed to work on MK3S+. I have no access to printer now to check the last one, if no one overtakes me, I'll do it tomorrow or the day after tomorrow.

[dawidpieper]

We can reduce flash usage by 14 bytes (MK3S) that way. Is it okay?

[gudnimg]

We can reduce flash usage by 14 bytes (MK3S) that way. Is it okay?

Sounds good 💪

[dawidpieper]

Seems to work on MK3S plus with MMU2S