-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M850 add possibility to set sheet as active #4328
Conversation
|
My oversight. Now I standardized the formatting in all the code responsible for this gCode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very sensible to me. @gudnimg what do you think?
iPindaC = eeprom_read_byte(&EEPROM_Sheets_base->s[iSel].pinda_temp); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to have an empty line like the other block
I made suggested optimizations, but as for the last if statement, I think the code may be a bit less readable now. Previously only conditions for bHasXXX were used and I think the compiler optimizes it well. But these are only my feelings. :) |
I don't know AVR architecture as well. In fact I'm not sure if statement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I have not tested the changes.
Thanks, original commit seemed to work on MK3S+. I have no access to printer now to check the last one, if no one overtakes me, I'll do it tomorrow or the day after tomorrow. |
We can reduce flash usage by 14 bytes (MK3S) that way. Is it okay? |
Sounds good 💪 |
Seems to work on MK3S plus with MMU2S |
#2201 added possibility to set sheet parameters using new M850 gCode, but there still lacks possibility to set or check what sheet is active.
Added
A
parameter to set sheet as Active.Related to #3610
New usage
M850 S[sheet] Z[offset] L[label] B[Bed temp] P[PINDA temp] A[is active]
A1
enables the selected sheetA
set to 0 or missing, current status is reported