Fix issue with eFilamentAction not cleared correctly
#4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't clear eFilamentAction in every case in mFilamentItem() mFilamentItem() can trigger a call to M701 and M702 e.g. for Autoloading and eFilamentAction must be cleared by the gcode to prevent the user from triggering another Autoload (which will crashe the FW) The same applies to submenus. Now the MMU submenus clear eFilamentAction only when the action is done. For MMU Unload Filament item, eFilamentAction is only cleared after the unload_filament() call is done running. This fixes an issue where the menu item can be selected again while the first unload is still running.
Change in memory: Flash: -156 bytes SRAM: 0 bytes
gudnimg
force-pushed
the
fix-filament-actions
branch
from
ad14f19
to
1ca50bc
Compare
gudnimg
changed the title
eFilamentAction not cleared correctlyeFilamentAction not cleared correctly
DRracer
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #4308 which did not resolve the issue correctly.
Now
eFilamentActionis only cleared by the submenus or the queued gcodes (M701/M702)Similarly to the Preheat menu, now if the filament action is cancelled in the MMU menus (when selecting filament) then
eFilamentActionis reset toNone. Same applies to when the MMU operation is done running. Previously it was never reset.Autoloading feature was tested by @sarusani, see #4308 (comment)