Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to use an existing config file for recursor or auth… #135

Merged
merged 4 commits into from
May 6, 2024

Conversation

murphy83
Copy link
Contributor

@murphy83 murphy83 commented May 3, 2024

Idea to have the option to use an already existing (eg. externally generated) config file for recursor or authorative power-dns-mysql).
The behavior is controlled by setting the environment variable USE_EXISTING_CONFIG_FILE to "true". Disabled by default.

…orative mysql-powerdns-server, in case the configuration file is handed in from a volume or bind mount (in which it should be mounted as read only!).
@pschiffe
Copy link
Owner

pschiffe commented May 3, 2024

Hello @murphy83 , thank you for your contribution. I'm OK with this change, however, could you update also the pdns-pgsql image, so both images (pdns-pgsql and pdns-mysql) are equal feature-wise? Thank you.

@murphy83
Copy link
Contributor Author

murphy83 commented May 3, 2024

I was thinking about this idea already, however I am still not 100% sure about the path to follow, as usually refrain from "just duplicating code". So I am a bit tempted to use something like a functions-file to include for the parts that are valid for both Postgres and MySQL/MariaDB.
Let me know what you think fits better in your opinion.

@pschiffe
Copy link
Owner

pschiffe commented May 3, 2024

Feel free to do what you prefer. I've kept it separate as it's really not that much code, it's fairly simple and not updated that often.

@murphy83
Copy link
Contributor Author

murphy83 commented May 3, 2024

OK I think I will set to work on this in the evening.

pdns-mysql/docker-entrypoint.sh Show resolved Hide resolved
pdns-pgsql/docker-entrypoint.sh Outdated Show resolved Hide resolved
pdns-pgsql/docker-entrypoint.sh Show resolved Hide resolved
@murphy83
Copy link
Contributor Author

murphy83 commented May 6, 2024

Indeed ... this function was defined but never called ...

@pschiffe pschiffe merged commit 3ba3021 into pschiffe:master May 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants