-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(github-actions): migrate tests to GitHub Actions #145
Conversation
Migrate PubNub SDK test suite from Travis to GitHub Actions.
Add missing `uses` in acceptance test job.
Remove `runner.os` usage as runs group identifier.
Fix type because of which empty `os` passed to runner image.
Build dependencies and run tests using local GitHub actions. fix(build): fix 'clean' targets Fix issue because of which `clean` target always exited with error.
Move unit / integration test suite calling code from action into corresponding bash files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -77,4 +77,5 @@ pubnub_proxy_unittest: $(PROJECT_SOURCEFILES) $(PROXY_PROJECT_SOURCEFILES) pubnu | |||
#$(GCOVR) -r . --html --html-details -o coverage.html | |||
|
|||
clean: | |||
rm pubnub_core_unit_test.so pubnub_timer_list_unit_test.so pubnub_proxy_unit_test.so *.gcda *.gcno *.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that.
It probably closes the #108.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test(github-actions): migrate tests to GitHub Actions
Migrate PubNub SDK test suite from Travis to GitHub Actions.
Closes #108 #109