Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(github-actions): migrate tests to GitHub Actions #145

Merged
merged 41 commits into from
Dec 5, 2022

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Nov 30, 2022

test(github-actions): migrate tests to GitHub Actions

Migrate PubNub SDK test suite from Travis to GitHub Actions.

Closes #108 #109

Migrate PubNub SDK test suite from Travis to GitHub Actions.
Add missing `uses` in acceptance test job.
Remove `runner.os` usage as runs group identifier.
Fix type because of which empty `os` passed to runner image.
Build dependencies and run tests using local GitHub actions.

fix(build): fix 'clean' targets

Fix issue because of which `clean` target always exited with error.
@parfeon parfeon marked this pull request as ready for review December 2, 2022 23:48
@parfeon parfeon requested a review from a user December 2, 2022 23:48
Copy link
Contributor

@Xavrax Xavrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -77,4 +77,5 @@ pubnub_proxy_unittest: $(PROJECT_SOURCEFILES) $(PROXY_PROJECT_SOURCEFILES) pubnu
#$(GCOVR) -r . --html --html-details -o coverage.html

clean:
rm pubnub_core_unit_test.so pubnub_timer_list_unit_test.so pubnub_proxy_unit_test.so *.gcda *.gcno *.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that.
It probably closes the #108.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@parfeon parfeon merged commit 328e80a into master Dec 5, 2022
@parfeon parfeon deleted the test/switch-to-actions branch December 5, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make -f posix.mk clean target appears broken
2 participants