Fixes for windows.mk openssl makefile CLEN-2403
#200
+2,906
−1,772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the posix.mk makefile. https://pubnub.atlassian.net/browse/CLEN-2403
stephenlb
requested review from
Xavrax,
parfeon,
seba-aln and
KGronek-Pubnub
as code owners
stephenlb
changed the title
windows.mk default objects to build
stephenlb
changed the title
windows.mk default objects to buildwindows.mk default build objects
The `+=` operator in windows.mk makefiles seems to cause issues.
stephenlb
changed the title
windows.mk default build objectswindows.mk openssl makefile
stephenlb
changed the title
windows.mk openssl makefile windows.mk openssl makefile CLEN-2403
Restructure Makefiles (for `nmake` and `make`) to reduce amount of repeated declarations.
Don't use `extern "C"` by default for builds.
|
Additional flags for C/CPP can be set with: |
|
@stephenlb I need to change PR description, so I'm keeping your original message here:
|
|
Sounds good! |
parfeon
added
status: done
Use callback preprocessing macros. refactor: remove redundant libs Remove redundant libraries import from subscribe event engine.
…ent Engine enabled
`nmake` not as flexible as `make` and has set of limitations which needs to be handled.
Fix paths to the custom OpenSSL location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(custom-flags): added the way to set additional compiler flags
Additional flags for C/CPP can be set with:
USER_C_FLAGS/USER_CXX_FLAGSfix(Makefile): fix missed
pbbase64.cFix because of which one of the source files has been missed for Windows.
fix(Makefile): fix Makefile macro for Windows
Fix issue with unsupported concatenation of sources files / definitions (
+=).refactor(makefiles): refactor Makefiles
Refactor our
Makefilesfrom different folders and platforms to useincludedirectives to include shared definitions, flags, source files.