Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve python version flexibility #845

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Improve python version flexibility #845

merged 1 commit into from
Feb 15, 2024

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Feb 12, 2024

  • Changes the default CI image to centos9
    • Before merging let's make sure the older branches we care about have already had their template configs updated to specify the old image. pulpcore, pulp_rpm are already done, pulp_container has PRs up, not sure about the rest
  • Fixes hardcoded references to Python 3.8 in the template

[noissue]

@@ -26,7 +26,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: "3.8"
python-version: "latest"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: none of these are in the template, it's the CI for the template itself

README.md Show resolved Hide resolved
plugin-template Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dralley
Copy link
Contributor Author

dralley commented Feb 15, 2024

@gerrod3 Looking at the test failure.. this line of code doesn't even exist in recent versions, we replaced aiohttp a full year ago

https://github.com/pulp/plugin_template/actions/runs/7911045981/job/21594626348?pr=845#step:15:133

https://github.com/pulp/pulpcore/pull/3575/files

Any idea how this would be happening?

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, but also not a thing i want to hold off for.
Let's get this forward with!

README.md Outdated Show resolved Hide resolved
@gerrod3
Copy link
Contributor

gerrod3 commented Feb 15, 2024

@gerrod3 Looking at the test failure.. this line of code doesn't even exist in recent versions, we replaced aiohttp a full year ago

https://github.com/pulp/plugin_template/actions/runs/7911045981/job/21594626348?pr=845#step:15:133

https://github.com/pulp/pulpcore/pull/3575/files

Any idea how this would be happening?

We need to update this bootstrap line: https://github.com/pulp/plugin_template/blob/main/templates/bootstrap/requirements.txt#L1
CatDog is getting bootstrapped with a super old version of pulpcore that uses old requirements that are not compatible with python 3.11

@dralley
Copy link
Contributor Author

dralley commented Feb 15, 2024

@gerrod3 @mdellweg If we want to keep the older branches of various plugins using the older CI images, and I assume we do if our goal is maximal stability, then we need to do a round of CI updates to set the ci_base_image template var on all of the old branches.

The easiest way to do that is trigger the action right now prior to merging this PR, as it will fill out the default automatically. This is already done for pulpcore, pulp_rpm, and pulp_container but it doesn't look like ansible or gem are updated (beyond the main branch), and I don't have permissions to trigger the actions in those repos.

@gerrod3
Copy link
Contributor

gerrod3 commented Feb 15, 2024

The easiest way to do that is trigger the action right now prior to merging this PR, as it will fill out the default automatically. This is already done for pulpcore, pulp_rpm, and pulp_container but it doesn't look like ansible or gem are updated (beyond the main branch), and I don't have permissions to trigger the actions in those repos.

pulp_gem and pulp_ansible have been updated. We still need to update pulp_ostree and pulp_deb. And do we need to do anything for pulp_file?

@dralley
Copy link
Contributor Author

dralley commented Feb 15, 2024

pulp_file no longer has independent CI, so no.

@mdellweg
Copy link
Member

pulp_file no longer has independent CI, so no.

Stable branches do...

@dralley
Copy link
Contributor Author

dralley commented Feb 15, 2024

That's true

@dralley dralley merged commit 69ef1f6 into pulp:main Feb 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants