Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate command reference in docs #797

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mdellweg
Copy link
Member

[noissue]

Review Checklist:

  • An issue is properly linked. [feature and bugfix only]
  • Tests are present or not feasible.
  • Commits are split in a logical way (not historically).

@mdellweg mdellweg marked this pull request as ready for review September 27, 2023 12:02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you need to change the way the main command is loaded for the docs building?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any downsides to this new approach?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i remember correctly, i wanted to have a way to defer plugin loading until one could select the plugins to load in a config file. But that never worked. So probably no.

@mdellweg mdellweg marked this pull request as draft October 5, 2023 08:05
@mdellweg
Copy link
Member Author

mdellweg commented Oct 5, 2023

I am still not proud, how the commands are enumerated (without the PulpContexts in particular) here. Let's not merge it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants