Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply defaults to invokes #142

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 25, 2023

Fixes #115

This change applies default values as part of Invoke. This is inline with the behavior for resources.

@iwahbe iwahbe requested a review from a team October 25, 2023 18:01
@iwahbe iwahbe self-assigned this Oct 25, 2023
Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I understood the general context better here, but the change seems reasonable and the tests pass.

@iwahbe
Copy link
Member Author

iwahbe commented Oct 26, 2023

#114 has the bulk of the discussion on why this is needed. Basically, SDK default application is inconsistent, and non-existent when writing tests that are not full integration tests. We can do a good job here, and this makes the lives of our users simpler.

@iwahbe iwahbe merged commit 7cea218 into main Oct 26, 2023
5 checks passed
@iwahbe iwahbe deleted the iwahbe/115/apply-defaults-to-invokes branch October 26, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply provider side defaults to Invokes
2 participants