Error during provider startup for invalid provider configurations #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
force-pushed
the
iwahbe/205/prevent-invalid-struct-configurations
branch
from
283d9a3 to
c6a378d
Compare
Fixes #205 This PR introduces checks for non-pointer (`T` instead of `*T`) values that cannot be safely round-tripped. So far, these include enum and struct values. Previously, users could specify a property like: ``` fieldName T `pulumi:"name,optional"` ``` This would cause confusing behavior at runtime if `T` transitively contained an enum without a pointer (or map, or array) indirection. To avoid a complicated rule set for where pointers are needed, we require a pointer where the `,optional` was declared. Tests incoming shortly
iwahbe
force-pushed
the
iwahbe/205/prevent-invalid-struct-configurations
branch
from
c6a378d to
d661a3a
Compare
iwahbe
force-pushed
the
iwahbe/205/prevent-invalid-struct-configurations
branch
from
d661a3a to
2926d3d
Compare
t0yv0
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Looks good at first glance, the feature is very compelling, probably slightly breaking? If users used optional X before now this will force upgrading to *X. But I think it's worth it. Make illegal states unrepresentable.
I admit I'm not very thoroughly reviewing the code itself, LMK if it would be helpful to take the time to dig in. New codebase for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205
This PR introduces checks for non-pointer (
Tinstead of*T) values that cannot be safely round-tripped. So far, these include enum and struct values. Previously, users could specify a property like:This would cause confusing behavior at runtime if
Ttransitively contained an enum without a pointer (or map, or array) indirection. To avoid a complicated rule set for where pointers are needed, we require a pointer where the,optionalwas declared.