Fix linter deprecation warnings and enhance coverage #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
approved these changes
May 31, 2024
| @@ -16,15 +17,15 @@ linters: | |||
| - gofmt | |||
| - revive | |||
| - gosec | |||
| - gosimple | |||
| - govet | ||
| - ineffassign | ||
| - lll | ||
| - misspell | ||
| - nakedret | ||
| - unconvert | ||
| - paralleltest | ||
| - staticcheck |
Comment on lines
+326
to
+328
| type contextKey string | ||
|
|
||
| var migrationsKey = contextKey("migrations") |
There was a problem hiding this comment.
Slightly easier to just use an empty struct since you don't need to do anything with it. Zero bytes as a bonus.
var migrationsKey struct{}
Sure. Except this repo isn't under ci-mgmt at all currently... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some linter deprecation warnings and add the gosimple linter. Can be reviewed commit by commit.