Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spectra and spectra_components to nomenclature page #2264

Merged
merged 16 commits into from
Nov 5, 2024

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Oct 16, 2024

Linked: #2284

@kandersolar kandersolar added this to the v0.11.2 milestone Oct 18, 2024
@RDaxini
Copy link
Contributor Author

RDaxini commented Oct 19, 2024

Marking as a draft for now because it seems #2234 is close to being merged, so these variables can be added to the new glossary rather than the variables and symbols page

@RDaxini RDaxini marked this pull request as draft October 19, 2024 18:50
@RDaxini RDaxini changed the title add spectra and spectra_components to variables and symbols page add spectra and spectra_components to nomenclature page Nov 1, 2024
@RDaxini RDaxini marked this pull request as ready for review November 1, 2024 18:05
@RDaxini RDaxini mentioned this pull request Nov 1, 2024
7 tasks
docs/sphinx/source/user_guide/nomenclature.rst Outdated Show resolved Hide resolved
docs/sphinx/source/user_guide/nomenclature.rst Outdated Show resolved Hide resolved
pvlib/spectrum/irradiance.py Outdated Show resolved Hide resolved
pvlib/spectrum/spectrl2.py Outdated Show resolved Hide resolved
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@RDaxini
Copy link
Contributor Author

RDaxini commented Nov 5, 2024

All good suggestions @kandersolar thanks!

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RDaxini!

@kandersolar kandersolar merged commit afdcdd4 into pvlib:main Nov 5, 2024
26 checks passed
@RDaxini RDaxini deleted the spectra-variables branch November 5, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"spectral irradiance" variable defintion/standardisation suggestion
3 participants