Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error check to detect_clearsky #2281

Merged
merged 10 commits into from
Nov 15, 2024

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Oct 29, 2024

  • Closes More descriptive errors for detect_clearsky #2005
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Adds a check on window_length in clearsky.detect_clearsky to ensure window_length contains at least 3 data points.

@cwhanse cwhanse added this to the v0.11.2 milestone Oct 29, 2024
pvlib/clearsky.py Outdated Show resolved Hide resolved
pvlib/clearsky.py Outdated Show resolved Hide resolved
cwhanse and others added 2 commits October 30, 2024 13:24
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
pvlib/clearsky.py Outdated Show resolved Hide resolved
@cwhanse
Copy link
Member Author

cwhanse commented Nov 5, 2024

Adding a bit of scope here. #1784 added a function to lookup thresholds from Jordan and Hansen (2023). That paper extended the detect_clearsky algorithm to plane-of-array (POA) data. #1784 didn't update the docstring to describe the new capability.

pvlib/clearsky.py Outdated Show resolved Hide resolved
pvlib/clearsky.py Outdated Show resolved Hide resolved
@kandersolar kandersolar merged commit 5df830e into pvlib:main Nov 15, 2024
27 checks passed
@kandersolar
Copy link
Member

Thanks @cwhanse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More descriptive errors for detect_clearsky
3 participants