Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial pos mol #34

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Conversation

mariusaarsten
Copy link
Contributor

@mariusaarsten mariusaarsten commented Apr 16, 2024

Fixes #35

pyMBE.py Outdated Show resolved Hide resolved
testsuite/create_molecule_position.py Outdated Show resolved Hide resolved
@pm-blanco pm-blanco added the bug Something isn't working label Apr 16, 2024
@pm-blanco
Copy link
Collaborator

@mariusaarsten note that you need to change the name of the test in the Makefile, otherwise the CI crashes simply because it does not find the right file

@mariusaarsten
Copy link
Contributor Author

@pm-blanco Done! I think the pull request should be good now

Copy link
Collaborator

@pm-blanco pm-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariusaarsten it looks good to me now, thank you for your work!

@pm-blanco pm-blanco merged commit 8a8f2c5 into pyMBE-dev:main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: create_molecule(positions) only creates the fist molecule in the correct position
2 participants