Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual DOI if available #523

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use actual DOI if available #523

wants to merge 2 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 20, 2024

Noticed this while working on #520 and it bothered me overnight.

@pllim
Copy link
Contributor Author

pllim commented Nov 20, 2024

One of the failures is unrelated:

@lwasser
Copy link
Member

lwasser commented Nov 20, 2024

i wonder if this could be a lychee issue - i see this at the top of the issue. which is also odd. a bunch of warnings. because these links i thikjnk work

Run /home/runner/work/_actions/lycheeverse/lychee-action/v2.1.0/entrypoint.sh
/home/runner/work/_actions/lycheeverse/lychee-action/v2.1.0/entrypoint.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
GITHUB_TOKEN: ***
INPUT_TOKEN: ***
INPUT_ARGS: --verbose --no-progress _site/*.html
INPUT_DEBUG: false
INPUT_FAIL: true
INPUT_FAILIFEMPTY: true
INPUT_FORMAT: markdown
INPUT_JOBSUMMARY: true
INPUT_OUTPUT: lychee/out.md
[WARN ] Error creating request: InvalidPathToUri("/feed.xml")
[WARN ] Error creating request: InvalidPathToUri("/assets/css/main.css")
[WARN ] Error creating request: InvalidPathToUri("/images/favicon.ico")
[WARN ] Error creating request: InvalidPathToUri("/feed.xml")
[WARN ] Error creating request: InvalidPathToUri("/assets/css/main.css")
[WARN ] Error creating request: InvalidPathToUri("/images/favicon.ico")
[WARN ] Error creating request: InvalidPathToUri("/")
[WARN ] Error creating request: InvalidPathToUri("/images/logo.png")
[WARN ] Error creating request: InvalidPathToUri("/feed.xml")
[WARN ] Error creating request: InvalidPathToUri("/assets/css/main.css")
[WARN ] Error creating request: InvalidPathToUri("/images/favicon.ico")
[WARN ] Error creating request: InvalidPathToUri("/about-peer-review/index.html")
[WARN ] Error creating request: InvalidPathToUri("/partners.html")
[WARN ] Error creating request: InvalidPathToUri("/python-packages.html")
[WARN ] Error creating request: InvalidPathToUri("/")

Ok i see aother issue - i'm going to open a separate issue about this. the JOSS-approved link to sourmash (and this link ONLY seem to exist for sourmash), is definitely broken. it's trying to behave like a relative link when it should be an absolute link. This is a website code issue that we can fix to begin to trouble shoot.

@lwasser
Copy link
Member

lwasser commented Nov 21, 2024

#524

trying this - at a minimum it's fixing an actual broken link 😆 but if this works then we need to make sure that joss published packages have the badge in our issue template before the issue is closed.

@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2024

I don't grok #524 . Does this mean I should close this PR without merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants