Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal user lookup #1874

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Remove internal user lookup #1874

wants to merge 10 commits into from

Commits on Jul 12, 2024

  1. Remove lookup from watcher methods

    @dimitarOnGithub
    dimitarOnGithub committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    48cd70b View commit details
    Browse the repository at this point in the history

  2. Remove internal lookup from assign_issue 

    Also allow the user to provide a User object
    @dimitarOnGithub
    dimitarOnGithub committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c12a221 View commit details
    Browse the repository at this point in the history

  3. Update relevant code 

    - make the `get_user_identifier` method public.
- remove the no longer needed `_get_user_id`
    @dimitarOnGithub
    dimitarOnGithub committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b4e4aee View commit details
    Browse the repository at this point in the history

  4. Allow User as param for watcher methods 

    This commit allows users to pass a User object to the `add_watcher` and `remove_watcher` methods
    @dimitarOnGithub
    dimitarOnGithub committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    59d2376 View commit details
    Browse the repository at this point in the history

  5. Test cases

    @dimitarOnGithub
    dimitarOnGithub committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    77d3480 View commit details
    Browse the repository at this point in the history

  6. Update examples.rst

    @dimitarOnGithub
    dimitarOnGithub committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d6e15ce View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Docs & doc string fixes

    @dimitarOnGithub
    dimitarOnGithub committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b0b552e View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'main' into main

    @dimitarOnGithub
    dimitarOnGithub authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    974296e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Make auto lookup optional 

    - Introduce a new flag at init called 'with_lookup', by default set to True
- If set to True, it will emit a warning to the end user at initialization
- If set to True, automatic user lookup will be performed for the 'add_watcher', 'remove_watcher' and 'assign_issue' methods
    @dimitarOnGithub
    dimitarOnGithub committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    790732d View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6397dce View commit details
    Browse the repository at this point in the history