Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for py38 and enable py312 testing #1886

Merged
merged 1 commit into from
Aug 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ body:
attributes:
label: Python Interpreter version
description: The version(s) of Python used.
placeholder: "3.8"
placeholder: "3.9"
validations:
required: true
- type: checkboxes
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/jira_cloud_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
os: [ubuntu-latest]
# We only test a single version to prevent concurrent
# running of tests influencing one another
python-version: ["3.8"]
python-version: ["3.9"]

steps:
- uses: actions/checkout@v4
Expand All @@ -41,7 +41,7 @@ jobs:
python -m pip install --upgrade tox tox-gh-actions

- name: Test with tox
run: tox -e py38 -- -m allow_on_cloud
run: tox -e py39 -- -m allow_on_cloud
env:
CI_JIRA_TYPE: CLOUD
CI_JIRA_CLOUD_ADMIN: ${{ secrets.CLOUD_ADMIN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/jira_server_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
jira-version: [8.17.1]

steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
TOX_PARALLEL_NO_SPINNER: 1

steps:
- name: Switch to using Python 3.8 by default
- name: Switch to using Python 3.9 by default
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

- name: Install build dependencies
run: python3 -m pip install --user tox
Expand Down
28 changes: 23 additions & 5 deletions .github/workflows/tox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,14 @@ jobs:
lint
docs
pkg
# ^ arm64 runner is using py311 for matching python version used in AAP 2.5
platforms: linux,macos,linux-arm64:ubuntu-24.04-arm64-2core
py39:tox -e py39 --notest
py310:tox -e py310 --notest
py311:tox -e py311 --notest
py312:tox -e py312 --notest
py39-macos:tox -e py312 --notest
py312-macos:tox -e py312 --notest
# ^ macos is also used to validate arm64 building
platforms: linux,macos
skip_explode: "1"
build:
name: ${{ matrix.name }}
Expand All @@ -45,6 +51,13 @@ jobs:
matrix: ${{ fromJson(needs.prepare.outputs.matrix) }}
steps:

- name: Install package dependencies (ubuntu)
if: ${{ contains(matrix.os, 'ubuntu') }}
run: |
sudo apt remove -y docker-compose
sudo apt-get update -y
sudo apt-get --assume-yes --no-install-recommends install -y apt-transport-https curl libkrb5-dev

- uses: actions/checkout@v4
with:
fetch-depth: 0 # needed by setuptools-scm
Expand Down Expand Up @@ -138,8 +151,13 @@ jobs:
name: logs.zip
path: .

- name: Check for expected number of coverage reports
run: .github/check-coverage.sh
- name: Check for expected number of coverage.xml reports
run: |
JOBS_PRODUCING_COVERAGE=0
if [ "$(find . -name coverage.xml | wc -l | bc)" -ne "${JOBS_PRODUCING_COVERAGE}" ]; then
echo "::error::Number of coverage.xml files was not the expected one (${JOBS_PRODUCING_COVERAGE}): $(find . -name coverage.xml |xargs echo)"
exit 1
fi

# Single uploads inside check job for codecov to allow use to retry
# it when it fails without running tests again. Fails often enough!
Expand All @@ -160,7 +178,7 @@ jobs:
with:
name: ${{ matrix.name }}
# verbose: true # optional (default = false)
fail_ci_if_error: true
fail_ci_if_error: false
use_oidc: true # cspell:ignore oidc
files: "*/tests/output/reports/coverage.xml"

Expand Down
2 changes: 2 additions & 0 deletions bindep.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# gssapi pypi wheel build needs:
libkrb5-dev [platform:dpkg]
Loading
Loading