Skip to content

Commit

Permalink
Enable pandas type checking (#9213)
Browse files Browse the repository at this point in the history
* remove pandas from ignore missing imports

* add Any to dim arg of concat as placeholder

* allow sequence of np.ndarrays as coords in dataArray constructor

* fix several typing issues in tests

* fix more types

* more fixes

* more typing...

* we are getting there?

* who might have guessed it... more typing

* continue fixing typing issues

* fix some typed_ops

* fix last non-typed-ops errors

* update typed ops

* remove useless DaskArray type in scalar or array type

* fix missing import in type_checking

* fix import

* improve cftime offsets typing

* fix classvars

* fix some checks

* fix a broken test

* improve typing of test_concat

* fix broken concat

* add whats-new

---------

Co-authored-by: Maximilian Roos <m@maxroos.com>
  • Loading branch information
headtr1ck and max-sixty authored Jul 17, 2024
1 parent 7477fd1 commit 71fce9b
Show file tree
Hide file tree
Showing 35 changed files with 632 additions and 504 deletions.
2 changes: 2 additions & 0 deletions doc/whats-new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ Documentation
Internal Changes
~~~~~~~~~~~~~~~~

- Enable typing checks of pandas (:pull:`9213`).
By `Michael Niklas <https://github.com/headtr1ck>`_.

.. _whats-new.2024.06.0:

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ module = [
"netCDF4.*",
"netcdftime.*",
"opt_einsum.*",
"pandas.*",
"pint.*",
"pooch.*",
"pyarrow.*",
Expand Down
Loading

0 comments on commit 71fce9b

Please sign in to comment.