fix #29: set skip_empty_rows to False

pyexcel · Jan 24, 2017 · 9da79fb · 9da79fb
1 parent 930096c
commit 9da79fb
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 8 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -11,6 +11,14 @@ Updated
 #. `#19 <https://github.com/pyexcel/pyexcel-io/issues/19>`__,
    use cString by default
 
+0.3.2 - unreleased
+--------------------------------------------------------------------------------
+
+Updated
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+
+#. `#29 <https://github.com/pyexcel/pyexcel-io/issues/29>`_, change
+   skip_empty_rows to False by default
 
 0.3.1 - 21.01.2017
 --------------------------------------------------------------------------------

diff --git a/docs/source/conf.py b/docs/source/conf.py
@@ -17,8 +17,8 @@
 
 project = u'pyexcel-io'
 copyright = u'2015-2017 Onni Software Ltd.'
-version = '0.3.0'
-release = '0.3.1'
+version = '0.3.1'
+release = '0.3.2'
 exclude_patterns = []
 pygments_style = 'sphinx'
 html_theme = 'default'

diff --git a/pyexcel_io.yaml b/pyexcel_io.yaml
@@ -1,8 +1,8 @@
 overrides: "pyexcel.yaml"
 name: "pyexcel-io"
 nick_name: io
-version: 0.3.1
-release: 0.3.0
+version: 0.3.2
+release: 0.3.1
 dependencies:
   - ordereddict;python_version<"2.7"
 extra_dependencies:

diff --git a/pyexcel_io/sheet.py b/pyexcel_io/sheet.py
@@ -30,7 +30,7 @@ def __init__(self, sheet,
                  start_row=0, row_limit=-1,
                  start_column=0, column_limit=-1,
                  skip_row_func=None, skip_column_func=None,
-                 skip_empty_rows=True, row_renderer=None,
+                 skip_empty_rows=False, row_renderer=None,
                  **keywords):
         self._native_sheet = sheet
         self._keywords = {}

diff --git a/setup.py b/setup.py
@@ -10,7 +10,7 @@
 
 NAME = 'pyexcel-io'
 AUTHOR = 'C.W.'
-VERSION = '0.3.1'
+VERSION = '0.3.2'
 EMAIL = 'wangc_2011 (at) hotmail.com'
 LICENSE = 'New BSD'
 DESCRIPTION = (

diff --git a/tests/test_django_book.py b/tests/test_django_book.py
@@ -264,7 +264,7 @@ def test_empty_model(self):
         model = FakeDjangoModel()
         reader = DjangoModelReader(model)
         data = reader.to_array()
-        eq_(list(data), [[]])
+        eq_(list(data), [[], []])
 
 
 class TestMultipleModels:

diff --git a/tests/test_sql_book.py b/tests/test_sql_book.py
@@ -460,7 +460,7 @@ def test_sql(self):
         mysession = Session()
         sheet = SQLTableReader(mysession, Pyexcel)
         data = sheet.to_array()
-        content = [[]]
+        content = [[], []]
         # 'pyexcel' here is the table name
         assert list(data) == content
         mysession.close()