chore: use dependency-groups #2064
Open
+52
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/chore/usegroups
branch
from
113616f
to
831a075
Compare
joerick
reviewed
Oct 31, 2024
|
Cirrus: Failed to start an instance: FAILED_PRECONDITION: Monthly compute limit exceeded! Trying to restart now that it's next month. Also, saw this: |
henryiii
commented
Nov 1, 2024
henryiii
commented
Nov 1, 2024
henryiii
commented
Nov 1, 2024
henryiii
commented
Nov 1, 2024
henryiii
commented
Nov 1, 2024
mayeut
previously requested changes
Nov 2, 2024
|
Nox is just Python, and TOML support was added some time ago. So it's not required to wait for a nox release. I've updated the noxfile. |
henryiii
force-pushed
the
henryiii/chore/usegroups
branch
from
f9d716f
to
defaa97
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/usegroups
branch
from
defaa97
to
371426a
Compare
|
Okay to go in? |
mayeut
requested changes
Nov 17, 2024
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
|
Using a tool to read the dependency groups doesn't seem too bad to me; pip won't support this until 25.1 at the earliest. But we can either put this in of the next release, or the 3.0 release, or wait, this doesn't affect end users, only developers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using dependency groups for cibuildwheel itself.