cygwinccompiler: Get the compilers from sysconfig #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the CLANG64 environment of MSYS2, we should use clang instead of gcc. This patch gets the compiler from sysconfig which would be set when Python was built. Without this patch, the build fails when it's trying to check if the compiler is cygwin's one.
|
lgtm (There is potential for moving all this to customize_compiler() but we would have to somehow get rid of is_cygwincc(), or only call it when actually using the compiler, as it is currently expects the compiler to be set before customize_compiler(). Not clear, so let's keep the fix simple) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the CLANG64 environment of MSYS2, we should use clang
instead of gcc. This patch gets the compiler from sysconfig which
would be set when Python was built.
Without this patch, the build fails when it's trying to check if the
compiler is cygwin's one.