Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug failing CI #4110

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Debug failing CI #4110

merged 8 commits into from
Nov 16, 2023

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Nov 15, 2023

Summary of changes

In #4108 we started to see errors in the tests, which I did not manage to reproduce locally or in a container...
The purpose of this PR is to debug these errors which will hopefully help to fix them.

Closes

Pull Request Checklist

@abravalheri abravalheri changed the title Add debugging statements Debug failing CI Nov 15, 2023
@abravalheri
Copy link
Contributor Author

abravalheri commented Nov 15, 2023

Interestingly after adding the debug statements, the error goes away... Maybe a synchronisation problem?

I can see that there was recently a new release of filelock and pip... Maybe it is related? Or another test dependency...

@abravalheri abravalheri marked this pull request as ready for review November 16, 2023 13:48
@abravalheri
Copy link
Contributor Author

I did not manage to find out exactly what is happening, but the key seems to be synchronisation problems between multiple things running in parallel.

Pre-building the wheel and sdist files used in tests before running tox seem to solve the problem.

@abravalheri
Copy link
Contributor Author

Let's get this out of the way...

@abravalheri abravalheri merged commit 3f437ab into pypa:main Nov 16, 2023
23 checks passed
@abravalheri abravalheri deleted the investigate-errors branch November 16, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant