Ruff: lint pytest #4557
Ruff: lint pytest #4557
Conversation
| @@ -59,6 +63,13 @@ ignore = [ | |||
| [lint.flake8-annotations] | |||
| ignore-fully-untyped = true | |||
|
|
|||
| [lint.flake8-pytest-style] | |||
| parametrize-names-type = "csv" | |||
There was a problem hiding this comment.
I went with "csv" because it's the most used in the project currently. But I think I'd prefer the default of "tuple" See https://docs.astral.sh/ruff/rules/pytest-parametrize-names-wrong-type/ & https://docs.astral.sh/ruff/settings/#lint_flake8-pytest-style_parametrize-names-type
| "PYI", # flake8-pyi | ||
| "UP", # pyupgrade | ||
| "TRY", | ||
| "YTT", # flake8-2020 | ||
| ] | ||
| ignore = [ | ||
| "PT007", # temporarily disabled, TODO: configure and standardize to preference | ||
| "PT011", # temporarily disabled, TODO: tighten expected error | ||
| "PT012", # pytest-raises-with-multiple-statements, avoid extra dummy methods for a few lines, sometimes we explicitly assert in case of no error |
There was a problem hiding this comment.
I felt like the changes PT012 was asking for didn't fit the style of a handful of current tests, would've added more boilerplate without helping that much prevent false-negatives.
Avasam
force-pushed
the
Ruff--lint-pytest
branch
2 times, most recently
from
d390533
to
a72efef
Compare
|
Patch coverage failure because coverage is not aggregated (jaraco/skeleton#130) AND integration tests are not run when modifying integration tests. To be considered ? |
| "PYI", # flake8-pyi | ||
| "UP", # pyupgrade | ||
| "TRY", | ||
| "YTT", # flake8-2020 | ||
| ] | ||
| ignore = [ | ||
| "PT007", # temporarily disabled, TODO: configure and standardize to preference | ||
| "PT011", # temporarily disabled, TODO: tighten expected error |
There was a problem hiding this comment.
I think I'd like to see astral-sh/ruff#5157 or astral-sh/ruff#6840 before enabling PT011
| yield | ||
|
|
||
| request.addfinalizer(_debug_info) | ||
| # Let's provide the maximum amount of information possible in the case | ||
| # it is necessary to debug the tests directly from the CI logs. | ||
| print("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~") | ||
| print("Temporary directory:") | ||
| map(print, tmp_path.glob("*")) | ||
| print("Virtual environment:") | ||
| run([venv_python, "-m", "pip", "freeze"]) |
There was a problem hiding this comment.
setuptools/tests/test_integration.py
Outdated
|
|
||
| yield cmd | ||
|
|
||
| # undo the monkeypatch, particularly needed under | ||
| # windows because of kept handle on cwd | ||
| monkeypatch.undo() | ||
| new_cwd.remove() | ||
| user_base.remove() | ||
| user_site.remove() | ||
| install_dir.remove() |
There was a problem hiding this comment.
Avasam
force-pushed
the
Ruff--lint-pytest
branch
from
6cb42ab
to
48a741d
Compare
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| @pytest.fixture(autouse=True) | |||
| def isolated_dir(tmpdir_cwd): | |||
| yield | |||
| return | |||
There was a problem hiding this comment.
Avasam
force-pushed
the
Ruff--lint-pytest
branch
4 times, most recently
from
d93e6e1
to
017a828
Compare
Avasam
force-pushed
the
Ruff--lint-pytest
branch
from
017a828
to
bafdf65
Compare
Avasam
force-pushed
the
Ruff--lint-pytest
branch
from
bafdf65
to
35873f1
Compare
Summary of changes
In this PR I've enabled https://docs.astral.sh/ruff/rules/#flake8-pytest-style-pt linting in Ruff and configured to the current preferences.
Pull Request Checklist
newsfragments/. (no user facing changes)(See documentation for details)