Add exception for old versions of importlib_metadata
#4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
commented
Aug 16, 2024
| if not hasattr(metadata, "EntryPoints"): # pragma: no cover | ||
| raise ImportError( | ||
| "`importlib-metadata` version is incompatible with `setuptools`. " | ||
| "Please install importlib-metadata>=4.6" # Equivalent to stdlib's in 3.10 |
There was a problem hiding this comment.
The choice of importlib-metadata>=4.6 is based on the fact that the if statement above accepts stdlib's version for Python 3.10 and according to importlib_metadata's docs that is equivalent to version 4.6.
So if the codebase works with importlib.metadata in Python 3.10 it should also work with importlib_metadata 4.6. I am not sure why pyproject.toml requires importlib_metadata>=6...
jaraco
changed the title
importlib_resourcesimportlib_metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add exception for old versions of
importlib_metadataCloses #4570
Pull Request Checklist
newsfragments/.(See documentation for details)