Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: remove checking is python >= 3.4 #1446

Merged
merged 2 commits into from
Oct 22, 2024
Merged

TST: remove checking is python >= 3.4 #1446

merged 2 commits into from
Oct 22, 2024

Conversation

kloczek
Copy link
Contributor

@kloczek kloczek commented Oct 1, 2024

  • Closes #xxxx
  • Tests added
  • Fully documented, including history.rst for all changes and api/*.rst for new API

@kloczek kloczek changed the title remove checkink is python >= 3.4 remove checking is python >= 3.4 Oct 1, 2024
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
@kloczek
Copy link
Contributor Author

kloczek commented Oct 1, 2024

This check is no longer needed.

@snowman2 snowman2 added the test Test related issues label Oct 1, 2024
@snowman2 snowman2 changed the title remove checking is python >= 3.4 TST: remove checking is python >= 3.4 Oct 1, 2024
@snowman2
Copy link
Member

snowman2 commented Oct 2, 2024

If you remove import sys and run pre-commit I believe this should work. Thanks 👍

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (efa3faa) to head (978aa0f).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
+ Coverage   96.40%   96.50%   +0.09%     
==========================================
  Files          20       20              
  Lines        1810     1830      +20     
==========================================
+ Hits         1745     1766      +21     
+ Misses         65       64       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snowman2 snowman2 merged commit 866a63f into pyproj4:main Oct 22, 2024
18 checks passed
@snowman2
Copy link
Member

Thanks @kloczek 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants