Handle NaNs #213
Open
Handle NaNs #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjsrey
added
WIP
|
sweet. looks like the only failure is probably small? |
|
@sjsrey do you want to get this into meta, or hang on until the next? |
Hang on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add functionality to handle missing values encoded as
numpy.NaN.The proposal is to classify the masked values (excluding NaNs), and then set the bin label for the missing observations to -1.
This would keep the labels as ints, rather than using
numpy.NaNwhich would change the labels to floats.This is a work-in progress PR to solicit comments and ideas.