Consistent hot/cold spot colors for local moran (#185)

* (bug) support graph in moran's viz

* additional fixes for graph support in esda viz

* Revert "additional fixes for graph support in esda viz"

This reverts commit b2acf98.

* additional fixes for supporting graph in esda viz

* (bug) make sure cold/hot spot colors are consistent

splot/_viz_esda_mpl.py

@@ -843,9 +843,8 @@ def _moran_loc_scatterplot(
 
         # colors
         spots = moran_hot_cold_spots(moran_loc, p)
-        hmap = colors.ListedColormap(
-            ["#bababa", "#d7191c", "#abd9e9", "#2c7bb6", "#fdae61"]
-        )
+        color_all = numpy.array(["#bababa", "#d7191c", "#abd9e9", "#2c7bb6", "#fdae61"])
+        hmap = colors.ListedColormap(color_all[list(numpy.unique(spots))])
 
     # define customization
     scatter_kwds.setdefault("alpha", 0.6)
@@ -870,9 +869,10 @@ def _moran_loc_scatterplot(
         if p is not None:
             fitline_kwds.setdefault("color", "k")
             scatter_kwds.setdefault("cmap", hmap)
-            scatter_kwds.setdefault("c", spots)
+            scatter_kwds.setdefault("c", numpy.sort(spots))
             ax.plot(lag, fit.predy, **fitline_kwds)
-            ax.scatter(moran_loc.z, fit.predy, **scatter_kwds)
+            ax.scatter(moran_loc.z[spots.argsort()], fit.predy[spots.argsort()],
+                       **scatter_kwds)
         else:
             scatter_kwds.setdefault("color", splot_colors["moran_base"])
             fitline_kwds.setdefault("color", splot_colors["moran_fit"])
@@ -890,9 +890,10 @@ def _moran_loc_scatterplot(
         if p is not None:
             fitline_kwds.setdefault("color", "k")
             scatter_kwds.setdefault("cmap", hmap)
-            scatter_kwds.setdefault("c", spots)
+            scatter_kwds.setdefault("c", numpy.sort(spots))
             ax.plot(moran_loc.y, a + b * moran_loc.y, **fitline_kwds)
-            ax.scatter(moran_loc.y, lag, **scatter_kwds)
+            ax.scatter(moran_loc.y[spots.argsort()], lag[spots.argsort()],
+                       **scatter_kwds)
         else:
             scatter_kwds.setdefault("c", splot_colors["moran_base"])
             fitline_kwds.setdefault("color", splot_colors["moran_fit"])