Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating check_spat_diag #147

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Deprecating check_spat_diag #147

merged 1 commit into from
Aug 28, 2024

Conversation

pedrovma
Copy link
Member

Check is done in check_weights.

This is to fix issue #146.

Check is done in check_weights.
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.6%. Comparing base (c9565aa) to head (9c42c02).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
spreg/ols_regimes.py 33.3% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #147     +/-   ##
=======================================
- Coverage   67.6%   67.6%   -0.0%     
=======================================
  Files         41      41             
  Lines       9626    9622      -4     
  Branches    1433    1433             
=======================================
- Hits        6508    6504      -4     
  Misses      2704    2704             
  Partials     414     414             
Files with missing lines Coverage Δ
spreg/ols.py 76.0% <100.0%> (+0.3%) ⬆️
spreg/twosls.py 82.5% <100.0%> (-0.1%) ⬇️
spreg/twosls_regimes.py 64.3% <100.0%> (-0.2%) ⬇️
spreg/twosls_sp_regimes.py 63.2% <ø> (-0.1%) ⬇️
spreg/user_output.py 58.0% <100.0%> (+0.3%) ⬆️
spreg/ols_regimes.py 31.8% <33.3%> (-0.7%) ⬇️

@pedrovma pedrovma merged commit d92edcb into pysal:main Aug 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants