Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change depreciated delim_whitespace #222

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Change depreciated delim_whitespace #222

merged 2 commits into from
Aug 19, 2024

Conversation

bowguy
Copy link
Contributor

@bowguy bowguy commented Aug 7, 2024

Change depreciated delim_whitespace=True to sep='\s+'

change
 delim_whitespace=True
 to
 sep='\s+'
Change
delim_whitespace=True
to
sep='\s+'
@bemcdonnell
Copy link
Member

@bowguy PR couldn't be more timely. I was getting that warning today and I was so annoyed that I just added the following to my code knowing it isn't the classy way to handle this. :)

import warnings
warnings.filterwarnings("ignore")

@aerispaha will ultimately need to approve this but until then, go ahead and add your name to the Authors list too.

@bowguy
Copy link
Contributor Author

bowguy commented Aug 8, 2024

The merge is blocked but looks like it is a configuration error on the bot, not the patch.

@bemcdonnell
Copy link
Member

@bowguy , I don’t see any issues with your PR. That action is failing since I think we are only setup to build the docs on a tag release. @aerispaha just needs to approve it since he’s central maintainer. Should be soon. Thanks for submitting this PR!

Copy link
Member

@aerispaha aerispaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowguy thanks for this contribution! Apologies for the delay (I'm just getting back from vacation).
I'll merge and prepare the release soon.

@aerispaha aerispaha merged commit 2d1ab06 into pyswmm:master Aug 19, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants