Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified test_snapshot_to_json_sets_primitive for 3.8 #1089

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

CulmoneY
Copy link
Contributor

@CulmoneY CulmoneY commented Sep 29, 2024

Proposed Changes

The test_snapshot_to_json_sets_primitive was failing exclusively in Python 3.8 due to the non-deterministic iteration order of Python sets. Since sets do not guarantee a particular order, the test would fail under certain conditions when the order was inconsistent.

To resolve this issue, I modified the test to focus on verifying the type and value fields of the JSON objects, while ignoring the id field. This removes any dependency on the iteration order and ensures the test passes reliably across different Python versions.
...

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@CulmoneY CulmoneY marked this pull request as ready for review September 29, 2024 04:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11089507941

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.051%

Totals Coverage Status
Change from base Build 11062551950: 0.0%
Covered Lines: 3057
Relevant Lines: 3321

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 667ea92 into pyta-uoft:master Sep 30, 2024
22 checks passed
@CulmoneY CulmoneY deleted the inconsistent-snapshot-test branch September 30, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants