Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add type hint to event.py, row_event.py, binlogfilereader.py #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ebang091
Copy link

@ebang091 ebang091 commented Sep 11, 2023

##요약
했던 과정 모두 squash 하여 하나의 commit으로 만들었습니다.

내용

event.py
rows_event.py
binlogfilereader.py
수정

참고

  • 좀 더 고려해야할 부분은, 멘토님이 알려주셨던 바와 같이 MysqlPacket 가져오는 부분입니다.
    import import pymysql 도 다시 확인해보니 밑줄이 그어져 있는데 해결방안과 이유를 알아보아야 할 것 같습니다.
스크린샷 2023-09-11 오후 5 12 38
  • 둘째로 Any 를 사용하지 않을 것인가도 고려해볼 만한 사항인 것 같습니다.

Co-authored-by:    suhwan-cheon <soo7652@naver.com>
Co-authored-by:    ebang091 <dskhe8@gmail.com>
Co-authored-by:    yangbaechu <abab_1212@naver.com>
Co-authored-by:    jaehyeonpy <jaehyeonpy@gmail.com>
@ebang091
Copy link
Author

conflict 해결이 잘 안되어있던 부분 재 수정해서 올리겠습니다!

@ebang091
Copy link
Author

ebang091 commented Sep 11, 2023

변경사항 : 이 부분의 두 줄코드를 한줄로 만들었던 코드가 잘 작동하지 않아서 다시 분리해서 변경해두었습니다. (489)
스크린샷 2023-09-11 오후 6 42 26

Co-authored-by:    suhwan-cheon <soo7652@naver.com>
Co-authored-by:    ebang091 <dskhe8@gmail.com>
Co-authored-by:    yangbaechu <abab_1212@naver.com>
Co-authored-by:    jaehyeonpy <jaehyeonpy@gmail.com>
@ebang091 ebang091 force-pushed the feature/typing-event,binlogfilereader branch from 0778fba to 5639d30 Compare September 11, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants