Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update managing-environments.md to have Poetry init before Poetry install #8927

Closed
wants to merge 2 commits into from

Conversation

AFirooz
Copy link

@AFirooz AFirooz commented Jan 30, 2024

Add poetry initiation

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

@dimbleby
Copy link
Contributor

I dont think this change makes sense, this section of the doc is describing work on an existing project.

poetry init and then immediately poetry install almost certainly isnt what anyone wants to do anyway, they likely want to add packages, write a README, etc

@radoering
Copy link
Member

I dont think this change makes sense, this section of the doc is describing work on an existing project.

I completely agree with this.

Nevertheless, thank you for your contribution.

@radoering radoering closed this Jan 31, 2024
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants