-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116622: Test updates for Android #117299
Conversation
@unittest.skipIf( | ||
sys.platform.startswith(("freebsd", "wasi")) | ||
or (sys.platform == "android" and platform.machine() == "x86_64"), | ||
f"this platform doesn't implement IEE 754-2008 properly") | ||
def test_fma_zero_result(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See discussion at #116667 (comment).
@erlend-aasland: Are you able to review this PR? It's a continuation of the previous Android test updates from #115918. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some nits. BTW, last time I checked, the sys.platform.startswith
idiom was still recommended practice. I'd prefer if we could follow that.
Lib/test/test_os.py
Outdated
# The Android testbed redirects the native stdout to a pipe, | ||
# which returns a different error code. | ||
known_errnos.append(errno.EACCES) | ||
if (sys.platform == "win32") or (e.errno in known_errnos): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parentheses are not needed.
Fixed.
I actually updated the |
@mhsmith, thanks for the heads-up, I missed that docs update (and I've must have looked at the 3.12 docs). Perhaps we should consider backporting that doc patch. |
- re-enable test_fcntl_64_bit on Linux aarch64, but disable it on all Android ABIs - use support.setswitchinterval in all relevant tests - skip test_fma_zero_result on Android x86_64 - accept EACCES when calling os.get_terminal_size on Android
This PR fixes various Android test issues which I've discovered over the last few weeks.