Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method (GH-117699) #117708

Merged
merged 3 commits into from
Apr 10, 2024
Merged

[3.12] gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method (GH-117699) #117708

merged 3 commits into from
Apr 10, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 10, 2024 •
edited by bedevere-app bot
Loading

(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev mail@sobolevn.me
Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

@sobolevn @AlexWaygood @miss-islington
pythongh-117692: Fix AttributeError in DocTestFinder on wrapped `…
7aea2ee 
…builtin_or_method` (pythonGH-117699)

(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This was referenced Apr 10, 2024
Closed
Merged
@AlexWaygood AlexWaygood enabled auto-merge (squash) April 10, 2024 09:54
@AlexWaygood AlexWaygood self-assigned this Apr 10, 2024
@AlexWaygood
Copy link
Member

Hmm, looks like the @doctest_skip_if decorator doesn't exist on Python 3.12

@AlexWaygood
Copy link
Member

Hmm, looks like the @doctest_skip_if decorator doesn't exist on Python 3.12

@sobolevn, reckon we should just backport the doctest_skip_if decorator to 3.12 as part of this PR? It seems pretty simple and low-risk

@sobolevn
Copy link
Member

See #116758 (comment)
I also thought that skipping this doctest would be easier, but the oirignal PR author had a valid point about doctest internals change in 3.13. We can go with if ...: in this branch.

@AlexWaygood AlexWaygood enabled auto-merge (squash) April 10, 2024 14:02
@AlexWaygood AlexWaygood merged commit 653ed76 into python:3.12 Apr 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexWaygood AlexWaygood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @AlexWaygood @sobolevn