gh-116622: Redirect stdout and stderr to system log when embedded in an Android app #118063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serhiy-storchaka: This PR is connected to the |
encukou
reviewed
Apr 23, 2024
encukou
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Thank you!
This looks good to me, modulo a few small nitpicks. I'll let @serhiy-storchaka resolve the conversations he started.
vstinner
reviewed
Apr 30, 2024
serhiy-storchaka
approved these changes
Apr 30, 2024
Co-authored-by: Victor Stinner <vstinner@python.org>
|
Merged. Let's see how it goes. It can be adjusted later if needed. Nice change @mhsmith. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…ed in an Android app (python#118063)
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…ed in an Android app (python#118063)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedded in an app on current versions of Android, there's no easy way to monitor the process's stdout and stderr. So, as specified in PEP 738, this PR redirects them to the system log, which can be viewed using the developer tools.