Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119180: Update the magic number #119397

Merged
merged 2 commits into from
May 25, 2024
Merged

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 22, 2024

PR #119321 added a comment about the magic number bump
but did not actually apply the new magic number.

Also, update PC/launcher.c.

but did not actually apply the new magic number.
@Eclips4
Copy link
Member

Eclips4 commented May 22, 2024

I've probably found a typo:

# Python 3.14a1 3600 (Add LOAD_COMMON_CONSTANT)

Since we are at a0 now, there's should be 3.14a0, isn't it?
If so, I think we can address that in this PR :)

@JelleZijlstra
Copy link
Member Author

a1 is right; the change is expected to be released in a1. You can see a little further up that there were numerous changes listed as 3.13a1 but none for 3.13a0.

@Eclips4
Copy link
Member

Eclips4 commented May 22, 2024

a1 is right; the change is expected to be released in a1. You can see a little further up that there were numerous changes listed as 3.13a1 but none for 3.13a0.

I was confused by an older entries where's a0 is used:

# Python 3.9a0 3420 (add LOAD_ASSERTION_ERROR #34880)
# Python 3.9a0 3421 (simplified bytecode for with blocks #32949)
# Python 3.9a0 3422 (remove BEGIN_FINALLY, END_FINALLY, CALL_FINALLY, POP_FINALLY bytecodes #33387)

It seems that the policy has changed since then?

@JelleZijlstra JelleZijlstra merged commit 84be524 into python:main May 25, 2024
36 checks passed
@JelleZijlstra JelleZijlstra deleted the pep649-magic branch May 25, 2024 00:32
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
PR python#119321 added a comment about the magic number bump
but did not actually apply the new magic number.
@JelleZijlstra JelleZijlstra restored the pep649-magic branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants