gh-123223: Adding hyperlink of argument in warnings.catch_warnings: #123231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
picnixz
reviewed
Aug 22, 2024
Doc/library/warnings.rst
Outdated
Comment on lines
591
to
593
| The definition of *category* and *lineno* are same as defined | ||
| at the top of :ref:`warning-filter` field. | ||
|
|
There was a problem hiding this comment.
I would put it after the documentation on the action argument.
See :ref:`warning-filter` for the meaning of the *category* and *lineno*
parameters.
nanjekyejoannah
approved these changes
Sep 25, 2024
picnixz
added
needs backport to 3.12
|
Thanks @Damien-Chen for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @Damien-Chen for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2024
…ngs: (pythonGH-123231) * Adding hyperlink of argument * Modify as reviewer suggested (cherry picked from commit 828583a) Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
|
GH-124527 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2024
…ngs: (pythonGH-123231) * Adding hyperlink of argument * Modify as reviewer suggested (cherry picked from commit 828583a) Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
|
GH-124528 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #123223, these arugment are mentioned at the top of the same page, so adding hyperlink so that when user at the buttom of the page, they are able to review the definition of those argument convinently.
📚 Documentation preview 📚: https://cpython-previews--123231.org.readthedocs.build/