-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #123775
Fix typos #123775
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
For the |
c796957
to
54e210b
Compare
@algonell Maybe I wasn't clear enough but by Note that you either need podman or docker to regenerate the configure script since it depends on a speciifc version of autoconf. If you have trouble with this, I can make it myself and open a pull request on your branch so that you can update it (but everytime you make a change to On platforms with shell scripts (Linux/MacOS), you can do the following: ./Tools/build/regen-configure.sh # create an up-to-date 'configure'
./configure # create an up-to-date 'Makefile'
make -j12 regen-all Then, you can verify the result via Slightly off-topic, but you don't need to merge |
My bad, one of my cleanups (occurence -> occurrence) was in aclocal.m4 (which is generated). Thank for your patience and the detailed explanation! |
It's fine, took me a while as well in the beginning to see that I needed to regen configure with a specific version of autoconf... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes on Objects/mimalloc/ should be made upstream in the https://github.com/microsoft/mimalloc/ project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, how do you look for spelling mistakes? do you use hunspell or aspell (or something else?)
(cherry picked from commit 9017b95)
GH-123866 is a backport of this pull request to the 3.13 branch. |
GH-123867 is a backport of this pull request to the 3.12 branch. |
Usually, I dislike backporting such changes to stable branches. But since this change modifies many files, I prefer to backport it to reduce the risk of conflicts of future backports. |
Merged, thanks. |
(cherry picked from commit 9017b95)
"you don't need to merge main into your branch unless you have conflicts." One does if one wants to test a revised PR against current main on one's own machine before pushing to github. However, one should 'git merge upstream/main' and not force-push. And testing is not an issue for typos in comments and docstrings. |
Fix typos in documentation, comments, etc.