Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101410: support custom messages for domain errors in the math module #124299

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-101410: support custom messages for domain errors in the math module #124299

wants to merge 10 commits into from
+108 −28

Commits on Sep 21, 2024

  1. pythongh-101410: support custom messages for domain errors in the mat… 

    …h module

This adds basic support to override default messages for domain errors
in the math_1() helper.  The sqrt(), atanh(), log2(), log10() and log()
functions were modified as examples.  New macro supports gradual
changing of error messages in other 1-arg functions.

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
    @CharlieZhao95 @skirpichev
    CharlieZhao95 and skirpichev committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    fb01518 View commit details
    Browse the repository at this point in the history

  2. +1

    @skirpichev
    skirpichev committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    05b55eb View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. address review: 

    * use PyOS_double_to_string
* drop loghelper arg
* don't print argument value in PyLong-branch of loghelper()
    @skirpichev
    skirpichev committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    a917cef View commit details
    Browse the repository at this point in the history

  2. address review: tests (few more, reformatting, etc)

    @skirpichev
    skirpichev committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    e8f49b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. address review: fix typo + cleanup

    @skirpichev
    skirpichev committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0bdbc72 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. address review: assertRaises -> assertRaisesRegex

    @skirpichev
    skirpichev committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e9bf987 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Merge branch 'master' into custom-dom-err-101410

    @skirpichev
    skirpichev committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    5b2040c View commit details
    Browse the repository at this point in the history

  2. Added support for error messages in math_1a(); gamma() as an example

    @skirpichev
    skirpichev committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    55396f9 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
    @skirpichev @picnixz
    skirpichev and picnixz authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    4905f1b View commit details
    Browse the repository at this point in the history

  4. Update Modules/mathmodule.c

    @skirpichev
    skirpichev authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    96e70f4 View commit details
    Browse the repository at this point in the history