-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: in venv table use executable names #124315
base: main
Are you sure you want to change the base?
Conversation
On my Windows computer, there's no |
I have both -- A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change for POSIX seems fine but per Vinay's note the Windows entry should read either "PowerShell" or indicate that both powershell.exe
and pwsh.exe
are supported.
A
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
unless something like the following is workable, I'll revert to the string PowerShell, and perform a soft reset please clarify Member preference Doc/library/venv.rst .. versionadded:: 3.8
PowerShell activation scripts installed under POSIX for PowerShell Core
- support.
+ support (users of PowerShell 5.1 replace pwsh.exe with powershell.exe in
+ the table). |
if neither the herein nor last comment's ideas are workable, I'll revert to the string PowerShell and perform a soft reset in the last comment it was suggested the text in a different approach might be adding a Note: directly after the text of support.
+ .. note::
+ Users of PowerShell 5.1 replace pwsh.exe with powershell.exe in
+ the table.
+
You don't specifically *need* to activate a virtual environment, |
changes PowerShell to pwsh and pwsh.exe
📚 Documentation preview 📚: https://cpython-previews--124315.org.readthedocs.build/