Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: in venv table use executable names #124315

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

musvaage
Copy link

@musvaage musvaage commented Sep 22, 2024

changes PowerShell to pwsh and pwsh.exe


📚 Documentation preview 📚: https://cpython-previews--124315.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 22, 2024
@vsajip
Copy link
Member

vsajip commented Sep 23, 2024

On my Windows computer, there's no pwsh.exe - PowerShell is powershell.exe. So I'm not sure if your change should be applied as is - perhaps have powershell.exe or pwsh.exe replace PowerShell?

@AA-Turner
Copy link
Member

On my Windows computer, there's no pwsh.exe - PowerShell is powershell.exe. So I'm not sure if your change should be applied as is - perhaps have powershell.exe or pwsh.exe replace PowerShell?

I have both -- pwsh.exe is PowerShell 7 and powershell.exe is PowerShell 5 (Windows PowerShell). This appears to be official.

A

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for POSIX seems fine but per Vinay's note the Windows entry should read either "PowerShell" or indicate that both powershell.exe and pwsh.exe are supported.

A

@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@musvaage
Copy link
Author

Windows entry

unless something like the following is workable, I'll revert to the string PowerShell, and perform a soft reset

please clarify Member preference

Doc/library/venv.rst

  .. versionadded:: 3.8
     PowerShell activation scripts installed under POSIX for PowerShell Core
-    support.
+    support (users of PowerShell 5.1 replace pwsh.exe with powershell.exe in
+    the table).

@musvaage
Copy link
Author

musvaage commented Sep 25, 2024

@AA-Turner

if neither the herein nor last comment's ideas are workable, I'll revert to the string PowerShell and perform a soft reset

in the last comment it was suggested the text in .. versionadded:: 3.8 could be supplemented

a different approach might be adding a Note: directly after the text of .. versionadded:: 3.8

     support.
  
+ .. note::
  
+     Users of PowerShell 5.1 replace pwsh.exe with powershell.exe in
+     the table.
+    
  You don't specifically *need* to activate a virtual environment,

@musvaage musvaage marked this pull request as draft September 29, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants