Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119333: PyContext watchers notify get interp from tstate #124444

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

fried
Copy link
Contributor

@fried fried commented Sep 24, 2024

This fixes a suggestion from #119335 that we should be getting the *interp from tstate instead.
Also attempting to clean up comments as suggested.

@fried
Copy link
Contributor Author

fried commented Sep 24, 2024

@kumaraditya303 Is this better?

@fried
Copy link
Contributor Author

fried commented Sep 24, 2024

Need a "skip news" label since the last pull had the news this is just a fix

Python/context.c Outdated Show resolved Hide resolved
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge now that Kumar approved.

Thanks for the updated PR!

@kumaraditya303 kumaraditya303 merged commit 46f5cbc into python:main Sep 26, 2024
37 checks passed
@fried fried deleted the context_watchers_fixup branch September 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants